Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3995)

Unified Diff: chrome/renderer/pepper/pnacl_translation_resource_host.cc

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jvoung, dmichael reviews Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/pepper/pnacl_translation_resource_host.cc
diff --git a/chrome/renderer/pepper/pnacl_translation_resource_host.cc b/chrome/renderer/pepper/pnacl_translation_resource_host.cc
index 75aa6d4b85bb13962d38533ae2ed830f4415497f..609ddecf3ba24a8cf1d47a10ba7e422d5f988e04 100644
--- a/chrome/renderer/pepper/pnacl_translation_resource_host.cc
+++ b/chrome/renderer/pepper/pnacl_translation_resource_host.cc
@@ -102,26 +102,30 @@ void PnaclTranslationResourceHost::SendRequestNexeFd(
}
void PnaclTranslationResourceHost::ReportTranslationFinished(
- PP_Instance instance) {
+ PP_Instance instance,
+ PP_Bool success) {
DCHECK(PpapiGlobals::Get()->
GetMainThreadMessageLoop()->BelongsToCurrentThread());
io_message_loop_->PostTask(
FROM_HERE,
base::Bind(&PnaclTranslationResourceHost::SendReportTranslationFinished,
this,
- instance));
+ instance,
+ success));
return;
}
void PnaclTranslationResourceHost::SendReportTranslationFinished(
- PP_Instance instance) {
+ PP_Instance instance,
+ PP_Bool success) {
DCHECK(io_message_loop_->BelongsToCurrentThread());
// If the channel is closed or we have been detached, we are probably shutting
// down, so just don't send anything.
if (!channel_)
return;
DCHECK(pending_cache_requests_.count(instance) == 0);
- channel_->Send(new NaClHostMsg_ReportTranslationFinished(instance));
+ channel_->Send(new NaClHostMsg_ReportTranslationFinished(instance,
+ PP_ToBool(success)));
}
void PnaclTranslationResourceHost::OnNexeTempFileReply(
« no previous file with comments | « chrome/renderer/pepper/pnacl_translation_resource_host.h ('k') | chrome/renderer/pepper/ppb_nacl_private_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698