Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

chrome/browser/nacl_host/pnacl_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/pnacl_host.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 162 matching lines @@
 
   CreateTemporaryFile(
       process_handle,
       base::Bind(&PnaclHost::ReturnMiss,
                  weak_factory_.GetWeakPtr(),
                  TranslationID(render_process_id, pp_instance)));
 }
 
 /////////////////// Cleanup
 
-void PnaclHost::TranslationFinished(int render_process_id, int pp_instance) {
+void PnaclHost::TranslationFinished(int render_process_id,
+                                    int pp_instance,
+                                    bool success) {

[dmichael (off chromium), 2013/08/06 18:53:58]

You're not actually doing anything with |success|. Is that intentional? It seems
like there ought to at least be a TODO, and IMHO it's helpful to comment out
success:
bool /* success */
to make it obvious it's unused.

[Derek Schuff, 2013/08/06 21:21:13]

I have another CL currently in flight which uses it. 

   DCHECK(thread_checker_.CalledOnValidThread());
   if (cache_state_ != CacheReady)
     return;
   PendingTranslationMap::iterator it(pending_translations_.find(
       TranslationID(render_process_id, pp_instance)));
   if (it == pending_translations_.end()) {
     LOG(ERROR) << "TranslationFinished: TranslationID " << render_process_id
                << "," << pp_instance << " not found.";
   } else {
     pending_translations_.erase(it);
   }
 }
 
 void PnaclHost::RendererClosing(int render_process_id) {
   if (cache_state_ != CacheReady)
     return;
   DCHECK(thread_checker_.CalledOnValidThread());
   for (PendingTranslationMap::iterator it = pending_translations_.begin();
        it != pending_translations_.end();) {
     PendingTranslationMap::iterator to_erase(it++);
     if (to_erase->first.first == render_process_id) {
       // clean up the open files
       pending_translations_.erase(to_erase);
     }
   }
 }