Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2230883003: Relax a check in CPDF_HintTables. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Relax a check in CPDF_HintTables. CPDF_HintTables::ReadSharedObjHintTable() unnecessarily constraints a FX_FILESIZE value to an int32_t. Relax this check, since the result will be stored in |m_szSharedObjOffsetArray| which is of FX_FILESIZE. Bad values in |m_szSharedObjOffsetArray| will still cause hint table loading to eventually fail. BUG=635565 Committed: https://pdfium.googlesource.com/pdfium/+/c18ffca5a35ab4b2218fadcca4006b3ea09e7875

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Lei Zhang
4 years, 4 months ago (2016-08-11 00:13:23 UTC) #6
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-11 16:39:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230883003/20001
4 years, 4 months ago (2016-08-11 16:39:14 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 16:39:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c18ffca5a35ab4b2218fadcca4006b3ea09e...

Powered by Google App Engine
This is Rietveld 408576698