Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2230873002: crypto: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

crypto: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/8ef165b4912db2109586b42a7cf324d8c79e6a3d Cr-Commit-Position: refs/heads/master@{#411628}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M crypto/hmac.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/nss_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/sha2.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 16:51:15 UTC) #7
davidben
lgtm
4 years, 4 months ago (2016-08-10 16:52:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230873002/20001
4 years, 4 months ago (2016-08-12 12:16:25 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 13:05:16 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:07:50 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ef165b4912db2109586b42a7cf324d8c79e6a3d
Cr-Commit-Position: refs/heads/master@{#411628}

Powered by Google App Engine
This is Rietveld 408576698