Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2230863002: mojo: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/ae7009a02050d02151f228524322d52c04153e91 Cr-Commit-Position: refs/heads/master@{#411618}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 17:09:23 UTC) #7
Anand Mistry (off Chromium)
lgtm
4 years, 4 months ago (2016-08-10 22:23:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230863002/20001
4 years, 4 months ago (2016-08-12 12:28:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 12:37:52 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:39:43 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae7009a02050d02151f228524322d52c04153e91
Cr-Commit-Position: refs/heads/master@{#411618}

Powered by Google App Engine
This is Rietveld 408576698