infra/bots/assets/go/create.py - Issue 2230853003: Package Go 1.6.2 in CIPD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/assets/go/create.py

Issue 2230853003: Package Go 1.6.2 in CIPD (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: clean Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/assets/go/create.py

diff --git a/infra/bots/assets/scripts/create.py b/infra/bots/assets/go/create.py

similarity index 71%

copy from infra/bots/assets/scripts/create.py

copy to infra/bots/assets/go/create.py

index 4f176085fbde447b9e5dca925f6c5e47fee08ef7..7121c155a53ba7bf9659e66b0e59404591078e9c 100755

--- a/infra/bots/assets/scripts/create.py

+++ b/infra/bots/assets/go/create.py

@@ -10,11 +10,13 @@

import argparse

+import subprocess

+GO_URL = "https://storage.googleapis.com/golang/go1.6.3.linux-amd64.tar.gz"

borenet 2016/08/10 14:40:29 Nit: 2 lines between top-level defs. This is Go 1

jcgregorio 2016/08/10 15:01:47 Yeah, 1.7 isn't listed as an available download on

def create_asset(target_dir):

"""Create the asset."""

- raise NotImplementedError('Implement me!')

+ subprocess.check_output("curl %s | tar -C %s -xzf -" % (GO_URL, target_dir), shell=True)

borenet 2016/08/10 14:40:29 Can we download and untar separately so that we ca

jcgregorio 2016/08/10 15:01:47 Done.

def main():

« no previous file with comments | « infra/bots/assets/go/common.py ('k') | infra/bots/assets/go/create_and_upload.py » ('j') | no next file with comments »