Package Go 1.6.2 in CIPD

Package Go 1.6.2 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003

Committed: https://skia.googlesource.com/skia/+/9d155afef4b562ead72b71d3a59c05b6461351df

[jcgregorio, 2016-08-10 13:18:55]

Description was changed from

==========
Package Go 1.7 in CIPD

BUG=skia:
==========

to

==========
Package Go 1.7 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003
==========

[jcgregorio, 2016-08-10 14:15:50]

jcgregorio@google.com changed reviewers:
+ borenet@google.com

[borenet, 2016-08-10 14:40:29]

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
File infra/bots/assets/go/create.py (right):

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
infra/bots/assets/go/create.py:15: GO_URL =
"https://storage.googleapis.com/golang/go1.6.3.linux-amd64.tar.gz"
Nit: 2 lines between top-level defs.

This is Go 1.6, not 1.7. Intentional?

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
infra/bots/assets/go/create.py:19: subprocess.check_output("curl %s | tar -C %s
-xzf -" % (GO_URL, target_dir), shell=True)
Can we download and untar separately so that we can avoid having to use
shell=True?

[jcgregorio, 2016-08-10 14:49:54]

Description was changed from

==========
Package Go 1.7 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003
==========

to

==========
Package Go 1.6.2 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003
==========

[jcgregorio, 2016-08-10 15:01:47]

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
File infra/bots/assets/go/create.py (right):

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
infra/bots/assets/go/create.py:15: GO_URL =
"https://storage.googleapis.com/golang/go1.6.3.linux-amd64.tar.gz"
On 2016/08/10 at 14:40:29, borenet wrote:
> Nit: 2 lines between top-level defs.
> 
> This is Go 1.6, not 1.7. Intentional?

Yeah, 1.7 isn't listed as an available download on https://golang.org/dl/. I've
updated the CL description.

https://codereview.chromium.org/2230853003/diff/40001/infra/bots/assets/go/cr...
infra/bots/assets/go/create.py:19: subprocess.check_output("curl %s | tar -C %s
-xzf -" % (GO_URL, target_dir), shell=True)
On 2016/08/10 at 14:40:29, borenet wrote:
> Can we download and untar separately so that we can avoid having to use
shell=True?

Done.

[borenet, 2016-08-10 15:07:34]

LGTM

[jcgregorio, 2016-08-10 15:08:33]

The CQ bit was checked by jcgregorio@google.com

[commit-bot: I haz the power, 2016-08-10 15:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:10:12]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[jcgregorio, 2016-08-10 15:17:52]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2016-08-10 15:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/2230853003/#ps80001
(title: "lint")

[commit-bot: I haz the power, 2016-08-10 15:17:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:44:46]

Description was changed from

==========
Package Go 1.6.2 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003
==========

to

==========
Package Go 1.6.2 in CIPD

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003

Committed:
https://skia.googlesource.com/skia/+/9d155afef4b562ead72b71d3a59c05b6461351df
==========

[commit-bot: I haz the power, 2016-08-10 15:44:46]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9d155afef4b562ead72b71d3a59c05b6461351df