MD Settings: Remove iron-pages usage from <settings-sync-page>.

chrome/browser/resources/settings/people_page/sync_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 /**
  * Names of the radio buttons which allow the user to choose his encryption
  * mechanism.
  * @enum {string}
@@ skipping 43 matching lines @@
 
   properties: {
     /** @private */
     pages: {
       type: Object,
       value: settings.PageStatus,
       readOnly: true,
     },
 
     /**
-     * The curerntly displayed page.
+     * The curernt page status.

[tommycli, 2016/08/11 22:14:28]

nit: typo

[dpapad, 2016/08/11 23:00:49]

Fixed.

      * @private {?settings.PageStatus}
      */
-    selectedPage_: {
+    pageStatus_: {
       type: String,
       value: settings.PageStatus.SPINNER,
     },
 
     /**
      * The current sync preferences, supplied by SyncBrowserProxy.
      * @type {settings.SyncPrefs|undefined}
      */
     syncPrefs: {
       type: Object,
@@ skipping 39 matching lines @@
     },
   },
 
   /** @override */
   attached: function() {
     this.addWebUIListener('page-status-changed',
                           this.handlePageStatusChanged_.bind(this));
     this.addWebUIListener('sync-prefs-changed',
                           this.handleSyncPrefsChanged_.bind(this));
 
-    if (settings.getCurrentRoute() == settings.Route.SYNC)
+    //if (settings.getCurrentRoute() == settings.Route.SYNC)

[dpapad, 2016/08/11 01:25:20]

Tommy, I commented out lines 127 and line 161 because otherwise the sync page is
very unfriendly to searching. It displays different contents when
force-rendered, and different when navigated to by a user. 

Do you think removing those lines will cause any problems?

[tommycli, 2016/08/11 22:14:28]

Fuuu I think that would be bad... I think I need to rework how this works before
it will play nice with search.

[dpapad, 2016/08/11 23:00:49]

Per our discussion, when the didNavigateToSyncPage() is called the C++ side of
things is being put into a "setup" mode, which is undesirable when the user has
not visited the page manually. So instead of commenting those lines out and
invoking "setup" mode from a forced-rendering, changed the default PageStatus to
CONFIGURE instead. This results in reasonable behavior for the most frequent
case (when no timeout occurred).

       this.onNavigateToPage_();
   },
 
   /** @override */
   detached: function() {
     if (settings.getCurrentRoute() == settings.Route.SYNC)
       this.onNavigateAwayFromPage_();
   },
 
   /** @protected */
   currentRouteChanged: function() {
     if (!this.isAttached)
       return;
 
     if (settings.getCurrentRoute() == settings.Route.SYNC)
       this.onNavigateToPage_();
     else
       this.onNavigateAwayFromPage_();
   },
 
+  /**
+   * @param {!settings.PageStatus} pageStatus
+   * @return {boolean}
+   * @private
+   */
+  isStatus_: function(pageStatus) {
+    return pageStatus == this.pageStatus_;
+  },
+
   /** @private */
   onNavigateToPage_: function() {
     // The element is not ready for C++ interaction until it is attached.
     assert(this.isAttached);
-    assert(settings.getCurrentRoute() == settings.Route.SYNC);
+    //assert(settings.getCurrentRoute() == settings.Route.SYNC);
 
     if (this.unloadCallback_)
       return;
 
     // Display loading page until the settings have been retrieved.
-    this.selectedPage_ = settings.PageStatus.SPINNER;
+    this.pageStatus_ = settings.PageStatus.SPINNER;
 
     this.browserProxy_.didNavigateToSyncPage();
 
     this.unloadCallback_ = this.onNavigateAwayFromPage_.bind(this);
     window.addEventListener('unload', this.unloadCallback_);
   },
 
   /** @private */
   onNavigateAwayFromPage_: function() {
     if (!this.unloadCallback_)
       return;
 
     this.browserProxy_.didNavigateAwayFromSyncPage();
 
     window.removeEventListener('unload', this.unloadCallback_);
     this.unloadCallback_ = null;
   },
 
   /**
    * Handler for when the sync preferences are updated.
    * @private
    */
   handleSyncPrefsChanged_: function(syncPrefs) {
     this.syncPrefs = syncPrefs;
-    this.selectedPage_ = settings.PageStatus.CONFIGURE;
+    this.pageStatus_ = settings.PageStatus.CONFIGURE;
 
     // If autofill is not registered or synced, force Payments integration off.
     if (!this.syncPrefs.autofillRegistered || !this.syncPrefs.autofillSynced)
       this.set('syncPrefs.paymentsIntegrationEnabled', false);
 
     // Hide the new passphrase box if the sync data has been encrypted.
     if (this.syncPrefs.encryptAllData)
       this.creatingNewPassphrase_ = false;
   },
 
@@ skipping 90 matching lines @@
   /**
    * Called when the page status updates.
    * @param {!settings.PageStatus} pageStatus
    * @private
    */
   handlePageStatusChanged_: function(pageStatus) {
     switch (pageStatus) {
       case settings.PageStatus.SPINNER:
       case settings.PageStatus.TIMEOUT:
       case settings.PageStatus.CONFIGURE:
-        this.selectedPage_ = pageStatus;
+        this.pageStatus_ = pageStatus;
         return;
       case settings.PageStatus.DONE:
         if (settings.getCurrentRoute() == settings.Route.SYNC)
           settings.navigateTo(settings.Route.PEOPLE);
         return;
       case settings.PageStatus.PASSPHRASE_FAILED:
-        if (this.selectedPage_ == this.pages.CONFIGURE &&
+        if (this.pageStatus_ == this.pages.CONFIGURE &&
             this.syncPrefs && this.syncPrefs.passphraseRequired) {
           this.$$('#existingPassphraseInput').invalid = true;
         }
         return;
     }
 
     assertNotReached();
   },
 
   /**
@@ skipping 65 matching lines @@
 
     passphraseInput.invalid = emptyPassphrase;
     passphraseConfirmationInput.invalid =
         !emptyPassphrase && mismatchedPassphrase;
 
     return !emptyPassphrase && !mismatchedPassphrase;
   },
 });
 
 })();