Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2230823002: Fix string_interpolation tests. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -110 lines) Patch
D tests/language/string_interpolation1_negative_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
A + tests/language/string_interpolation1_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
D tests/language/string_interpolation2_negative_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/language/string_interpolation2_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
D tests/language/string_interpolation3_negative_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/language/string_interpolation3_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
D tests/language/string_interpolation4_negative_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
A + tests/language/string_interpolation4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/language/string_interpolation5_negative_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/language/string_interpolation5_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
D tests/language/string_interpolation6_negative_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
A + tests/language/string_interpolation6_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-10 08:02:15 UTC) #2
ahe
lgtm
4 years, 4 months ago (2016-08-10 08:49:11 UTC) #3
Johnni Winther
4 years, 4 months ago (2016-08-10 09:39:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32bcf1e3b24e8b4722f8c747b1015e1fcc877d68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698