Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2230813003: Removed unused destroy() methods in CSSValue and StyleRule (Closed)

Created:
4 years, 4 months ago by sashab
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused destroy() methods in CSSValue and StyleRule Removed unused destroy() methods in CSSValue and StyleRule, which had custom destroy() methods when they were ref-counted. Since they are now garbage collected, this method is no longer called. Committed: https://crrev.com/99ec6c04713e6c92628a5d9fa2ec37251de72da3 Cr-Commit-Position: refs/heads/master@{#411572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -175 lines) Patch
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.cpp View 1 chunk +0 lines, -130 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sashab
4 years, 4 months ago (2016-08-11 03:46:27 UTC) #2
rjwright
On 2016/08/11 03:46:27, sashab wrote: lgtm
4 years, 4 months ago (2016-08-12 04:11:42 UTC) #3
sashab
timloh pls rs
4 years, 4 months ago (2016-08-12 04:12:16 UTC) #5
Timothy Loh
On 2016/08/12 04:12:16, sashab wrote: > timloh pls rs lgtmq
4 years, 4 months ago (2016-08-12 04:16:30 UTC) #6
Timothy Loh
On 2016/08/12 04:16:30, Timothy Loh wrote: > On 2016/08/12 04:12:16, sashab wrote: > > timloh ...
4 years, 4 months ago (2016-08-12 04:16:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230813003/1
4 years, 4 months ago (2016-08-12 04:17:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 07:24:41 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:26:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99ec6c04713e6c92628a5d9fa2ec37251de72da3
Cr-Commit-Position: refs/heads/master@{#411572}

Powered by Google App Engine
This is Rietveld 408576698