Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2129)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

Issue 2230803004: [Downloads] Use content:// URIs when sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Downloads] Use content:// URIs when sharing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
index 4f857bbd0cbc4a120a4dcea7d01ecb95f73a1f3e..61bff9fd56ec83e32faca19ebee4577b8be2a2a0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
@@ -39,8 +39,8 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
/** @return String showing where the download resides. */
abstract String getFilePath();
- /** @return A URI to where the file resides. */
- abstract Uri getUri();
+ /** @return The file where the download resides. */
+ abstract File getFile();
/** @return String to display for the file. */
abstract String getDisplayFileName();
@@ -71,6 +71,7 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
private static final String MIMETYPE_DOCUMENT = "text";
private final DownloadItem mItem;
+ private File mFile;
DownloadItemWrapper(DownloadItem item) {
mItem = item;
@@ -97,8 +98,9 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
}
@Override
- public Uri getUri() {
- return Uri.fromFile(new File(getFilePath()));
+ public File getFile() {
+ if (mFile == null) mFile = new File(getFilePath());
+ return mFile;
}
@Override
@@ -132,7 +134,7 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
boolean success = false;
String mimeType = mItem.getDownloadInfo().getMimeType();
- Uri fileUri = Uri.fromFile(new File(getFilePath()));
+ Uri fileUri = Uri.fromFile(getFile());
// Check if any apps can open the file.
Intent fileIntent = new Intent();
@@ -202,6 +204,7 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
/** Wraps a {@link OfflinePageDownloadItem}. */
static class OfflinePageItemWrapper extends DownloadHistoryItemWrapper {
private final OfflinePageDownloadItem mItem;
+ private File mFile;
OfflinePageItemWrapper(OfflinePageDownloadItem item) {
mItem = item;
@@ -228,8 +231,9 @@ abstract class DownloadHistoryItemWrapper implements TimedItem {
}
@Override
- public Uri getUri() {
- return Uri.fromFile(new File(getFilePath()));
+ public File getFile() {
+ if (mFile == null) mFile = new File(getFilePath());
+ return mFile;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698