Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2230803003: Revert of Fix a few gpu tests on Android (Closed)

Created:
4 years, 4 months ago by Julien Isorce Samsung
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a few gpu tests on Android (patchset #1 id:1 of https://codereview.chromium.org/2227893005/ ) Reason for revert: Failing tests on Android https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1242 Original issue's description: > Fix a few gpu tests on Android > > Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. > > For other tests it does not make sense to run them on Android because > there is either no entry in kSoftwareRenderingListJson to trigger > or no multi gpu configuration. > > About GpuProcess.skip_gpu_process, I could not reproduce the failure on > Nexus 4. > > BUG=611930 > > R=kbr@chromium.org > > TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a > Cr-Commit-Position: refs/heads/master@{#410998} TBR=kbr@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611930 Committed: https://crrev.com/270f29a49ca7deb830a554e5ffefb46619e4c4e6 Cr-Commit-Position: refs/heads/master@{#411057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -53 lines) Patch
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 1 chunk +16 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 7 chunks +18 lines, -38 lines 0 comments Download
M gpu/config/gpu_info_collector_android.cc View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Julien Isorce Samsung
Created Revert of Fix a few gpu tests on Android
4 years, 4 months ago (2016-08-10 10:12:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230803003/1
4 years, 4 months ago (2016-08-10 10:12:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 10:12:26 UTC) #5
Julien Isorce Samsung
On 2016/08/10 10:12:26, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 4 months ago (2016-08-10 10:30:41 UTC) #6
Zhenyao Mo
On 2016/08/10 10:30:41, Julien Isorce wrote: > On 2016/08/10 10:12:26, commit-bot: I haz the power ...
4 years, 4 months ago (2016-08-10 16:53:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230803003/1
4 years, 4 months ago (2016-08-10 16:53:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 16:54:58 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:58:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/270f29a49ca7deb830a554e5ffefb46619e4c4e6
Cr-Commit-Position: refs/heads/master@{#411057}

Powered by Google App Engine
This is Rietveld 408576698