MD Settings: methods to get root pages and sections

chrome/browser/resources/settings/settings_page/main_page_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Calls |readyTest| repeatedly until it returns true, then calls
  * |readyCallback|.
  * @param {function():boolean} readyTest
  * @param {!Function} readyCallback
  */
@@ skipping 42 matching lines @@
   /**
    * If possible, transitions to the current route's section (by expanding or
    * scrolling to it). If another transition is running, finishes or cancels
    * that one, then schedules this function again. This ensures the current
    * section is quickly shown, without getting the page into a broken state --
    * if currentRoute changes in between calls, just transition to the new route.
    * @private
    */
   tryTransitionToSection_: function() {
     var currentRoute = settings.getCurrentRoute();
-    var currentSection = this.getSection_(currentRoute.section);
+    var currentSection = this.getSection(currentRoute.section);
 
     // If an animation is already playing, try finishing or canceling it.
     if (this.currentAnimation_) {
       this.maybeStopCurrentAnimation_();
       // Either way, this function will be called again once the current
       // animation ends.
       return;
     }
 
     var promise;
@@ skipping 144 matching lines @@
 
   /** @private */
   scrollToSection_: function() {
     doWhenReady(
         function() {
           return this.scrollHeight > 0;
         }.bind(this),
         function() {
           // If the current section changes while we are waiting for the page to
           // be ready, scroll to the newest requested section.
-          var section = this.getSection_(settings.getCurrentRoute().section);
+          var section = this.getSection(settings.getCurrentRoute().section);
           if (section)
             section.scrollIntoView();
         }.bind(this));
   },
 
   /**
    * Helper function to get a section from the local DOM.
    * @param {string} section Section name of the element to get.
    * @return {?SettingsSectionElement}
-   * @private
    */
-  getSection_: function(section) {
+  getSection: function(section) {
     if (!section)
       return null;
     return /** @type {?SettingsSectionElement} */(
         this.$$('[section=' + section + ']'));

[dschuyler, 2016/08/10 17:16:17]

Removing the query from the other file loses the 
quotes in the section= query. Let's add them here
if we are removing the other:
'settings-section[section="' + route.section + '"]'
They are needed if we want to search for the empty
section ("").

[michaelpg, 2016/08/15 18:08:11]

Done.

   },
 
   /**
    * Enables or disables user scrolling, via overscroll: hidden. Room for the
    * hidden scrollbar is added to prevent the page width from changing back and
    * forth.
    * @param {boolean} enabled
    * @private
    */
   toggleScrolling_: function(enabled) {
     if (enabled) {
       this.scroller.style.overflow = '';
       this.scroller.style.width = '';
     } else {
       var scrollerWidth = this.scroller.clientWidth;
       this.scroller.style.overflow = 'hidden';
       var scrollbarWidth = this.scroller.clientWidth - scrollerWidth;
       this.scroller.style.width = 'calc(100% - ' + scrollbarWidth + 'px)';
     }
   }
 };
 
 /** @polymerBehavior */
 var MainPageBehavior = [
   settings.RouteObserverBehavior,
   MainPageBehaviorImpl,
 ];