envsetup: Stop looking at CHROME_ANDROID_OFFICIAL_BUILD.

envsetup: Stop looking at CHROME_ANDROID_OFFICIAL_BUILD.

Depends on https://chrome-internal-review.googlesource.com/159155

BUG=330631
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261509

[Yaron, 2014-04-03 16:27:18]

lgtm

I'm certain this one would require a doc update. Might only be on the internal
wiki.

[Nico, 2014-04-03 18:53:17]

On Thu, Apr 3, 2014 at 9:27 AM, <yfriedman@chromium.org> wrote:

> lgtm
>
> I'm certain this one would require a doc update. Might only be on the
> internal
> wiki.
>

Oh, do you do official builds often? Hm, then having to set 3 env vars
instead of just 1 seems worse. I'll see if I can remove at least one of
them – OFFICIAL_BUILD doesn't seem to be used anywhere for example.

Do you remember if version.py the only reason you added this? If so,
calling version.py with the right parameter from gyp could be enough so
that chrome/android doesn't need these env vars at all.


>
> https://codereview.chromium.org/223073002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yaron, 2014-04-03 19:25:36]

On 2014/04/03 18:53:17, Nico wrote:
> On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
> 
> > lgtm
> >
> > I'm certain this one would require a doc update. Might only be on the
> > internal
> > wiki.
> >
> 
> Oh, do you do official builds often? Hm, then having to set 3 env vars
> instead of just 1 seems worse. I'll see if I can remove at least one of
> them – OFFICIAL_BUILD doesn't seem to be used anywhere for example.

Not often. We used to recommend using "release official" for perf testing. I
think it affects compilation flags for Skia and some other places. I don't
believe it's necessary any more but maybe double-check with Marcus (although
he's ooo) or Tony
> 
> Do you remember if version.py the only reason you added this? If so,
> calling version.py with the right parameter from gyp could be enough so
> that chrome/android doesn't need these env vars at all.

Don't think it was the only reason.
> 
> 
> >
> > https://codereview.chromium.org/223073002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-03 19:45:18]

Ok, update the two pages I could find in the internal docs.


On Thu, Apr 3, 2014 at 12:25 PM, <yfriedman@chromium.org> wrote:

> On 2014/04/03 18:53:17, Nico wrote:
>
>  On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
>>
>
>  > lgtm
>> >
>> > I'm certain this one would require a doc update. Might only be on the
>> > internal
>> > wiki.
>> >
>>
>
>  Oh, do you do official builds often? Hm, then having to set 3 env vars
>> instead of just 1 seems worse. I'll see if I can remove at least one of
>> them - OFFICIAL_BUILD doesn't seem to be used anywhere for example.
>>
>
> Not often. We used to recommend using "release official" for perf testing.
> I
> think it affects compilation flags for Skia and some other places. I don't
> believe it's necessary any more but maybe double-check with Marcus
> (although
> he's ooo) or Tony
>
>
>  Do you remember if version.py the only reason you added this? If so,
>> calling version.py with the right parameter from gyp could be enough so
>> that chrome/android doesn't need these env vars at all.
>>
>
> Don't think it was the only reason.
>
>
>  >
>> > https://codereview.chromium.org/223073002/
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
>
>
> https://codereview.chromium.org/223073002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-03 19:45:28]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-03 19:45:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/223073002/1

[Nico, 2014-04-03 19:46:10]

(And sent out https://codereview.chromium.org/217833006/ to remove
OFFICIAL_BUILD=1 from compile.py; I'll merge this to the internal android
buildbot once it's been in the chromium tree for a while.)


On Thu, Apr 3, 2014 at 12:45 PM, Nico Weber <thakis@chromium.org> wrote:

> Ok, update the two pages I could find in the internal docs.
>
>
> On Thu, Apr 3, 2014 at 12:25 PM, <yfriedman@chromium.org> wrote:
>
>> On 2014/04/03 18:53:17, Nico wrote:
>>
>>  On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
>>>
>>
>>  > lgtm
>>> >
>>> > I'm certain this one would require a doc update. Might only be on the
>>> > internal
>>> > wiki.
>>> >
>>>
>>
>>  Oh, do you do official builds often? Hm, then having to set 3 env vars
>>> instead of just 1 seems worse. I'll see if I can remove at least one of
>>> them - OFFICIAL_BUILD doesn't seem to be used anywhere for example.
>>>
>>
>> Not often. We used to recommend using "release official" for perf
>> testing. I
>> think it affects compilation flags for Skia and some other places. I don't
>> believe it's necessary any more but maybe double-check with Marcus
>> (although
>> he's ooo) or Tony
>>
>>
>>  Do you remember if version.py the only reason you added this? If so,
>>> calling version.py with the right parameter from gyp could be enough so
>>> that chrome/android doesn't need these env vars at all.
>>>
>>
>> Don't think it was the only reason.
>>
>>
>>  >
>>> > https://codereview.chromium.org/223073002/
>>> >
>>>
>>
>>  To unsubscribe from this group and stop receiving emails from it, send an
>>>
>> email
>>
>>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>>
>>
>>
>>
>> https://codereview.chromium.org/223073002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-04-03 19:48:20]

Change committed as 261509

[pasko, 2014-05-07 09:06:35]

On 2014/04/03 18:53:17, Nico wrote:
> On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
> 
> > lgtm
> >
> > I'm certain this one would require a doc update. Might only be on the
> > internal
> > wiki.
> >
> 
> Oh, do you do official builds often? Hm, then having to set 3 env vars
> instead of just 1 seems worse. I'll see if I can remove at least one of
> them – OFFICIAL_BUILD doesn't seem to be used anywhere for example.
> 
> Do you remember if version.py the only reason you added this? If so,
> calling version.py with the right parameter from gyp could be enough so
> that chrome/android doesn't need these env vars at all.

Folks, the description of this CL is a bit confusing. A bunch of folks in LON
and PAR are _always_ looking at release official builds. I've been doing that
with CHROME_ANDROID_OFFICIAL_BUILD and did not notice the documentation change.
Can you please send a PSA how the documentation changed and what the plan is?

[pasko, 2014-05-07 09:39:46]

On 2014/05/07 09:06:35, pasko wrote:
> On 2014/04/03 18:53:17, Nico wrote:
> > On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
> > 
> > > lgtm
> > >
> > > I'm certain this one would require a doc update. Might only be on the
> > > internal
> > > wiki.
> > >
> > 
> > Oh, do you do official builds often? Hm, then having to set 3 env vars
> > instead of just 1 seems worse. I'll see if I can remove at least one of
> > them – OFFICIAL_BUILD doesn't seem to be used anywhere for example.
> > 
> > Do you remember if version.py the only reason you added this? If so,
> > calling version.py with the right parameter from gyp could be enough so
> > that chrome/android doesn't need these env vars at all.
> 
> Folks, the description of this CL is a bit confusing. A bunch of folks in LON
> and PAR are _always_ looking at release official builds. I've been doing that
> with CHROME_ANDROID_OFFICIAL_BUILD and did not notice the documentation
change.
> Can you please send a PSA how the documentation changed and what the plan is?

One bonus confusion: we have two internal pages referencing official build, the
instructions are slightly different.

[Yaron, 2014-05-07 17:24:39]

On 2014/05/07 09:39:46, pasko wrote:
> On 2014/05/07 09:06:35, pasko wrote:
> > On 2014/04/03 18:53:17, Nico wrote:
> > > On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
> > > 
> > > > lgtm
> > > >
> > > > I'm certain this one would require a doc update. Might only be on the
> > > > internal
> > > > wiki.
> > > >
> > > 
> > > Oh, do you do official builds often? Hm, then having to set 3 env vars
> > > instead of just 1 seems worse. I'll see if I can remove at least one of
> > > them – OFFICIAL_BUILD doesn't seem to be used anywhere for example.
> > > 
> > > Do you remember if version.py the only reason you added this? If so,
> > > calling version.py with the right parameter from gyp could be enough so
> > > that chrome/android doesn't need these env vars at all.
> > 
> > Folks, the description of this CL is a bit confusing. A bunch of folks in
LON
> > and PAR are _always_ looking at release official builds. I've been doing
that
> > with CHROME_ANDROID_OFFICIAL_BUILD and did not notice the documentation
> change.
> > Can you please send a PSA how the documentation changed and what the plan
is?
> 
> One bonus confusion: we have two internal pages referencing official build,
the
> instructions are slightly different.

Sorry for any confusion. Nico mentioned that he updated the internal pages (see
above) but perhaps a spot was missed?

AFAIK, official build doesn't do anything differently anymore (it used to) from
release build. Is that not the case?

[Nico, 2014-05-07 22:48:21]

Hi pasko,

can you send me a link to the wrong wiki page? To do an official
build, you do the same as on desktop (I think it's

GYP_DEFINES="OS=android branding=Chrome buildtype=Official" gclient runhooks
OFFICIAL_BUILD=1 CHROME_BUILD_TYPE=_official ninja -C out/Release chrome_apk

if I remember correctly.)

I figured that if people do official builds, they'd notice if they
suddenly stopped doing that and would then find this CL. There were so
many changes to envsetup that sending out a PSA for each would've
meant that people would quickly learn to ignore all PSAs that I send
:-)

On Wed, May 7, 2014 at 10:24 AM,  <yfriedman@chromium.org> wrote:
> On 2014/05/07 09:39:46, pasko wrote:
>>
>> On 2014/05/07 09:06:35, pasko wrote:
>> > On 2014/04/03 18:53:17, Nico wrote:
>> > > On Thu, Apr 3, 2014 at 9:27 AM, <mailto:yfriedman@chromium.org> wrote:
>> > >
>> > > > lgtm
>> > > >
>> > > > I'm certain this one would require a doc update. Might only be on
>> > > > the
>> > > > internal
>> > > > wiki.
>> > > >
>> > >
>> > > Oh, do you do official builds often? Hm, then having to set 3 env vars
>> > > instead of just 1 seems worse. I'll see if I can remove at least one
>> > > of
>> > > them - OFFICIAL_BUILD doesn't seem to be used anywhere for example.
>> > >
>> > > Do you remember if version.py the only reason you added this? If so,
>> > > calling version.py with the right parameter from gyp could be enough
>> > > so
>> > > that chrome/android doesn't need these env vars at all.
>> >
>> > Folks, the description of this CL is a bit confusing. A bunch of folks
>> > in
>
> LON
>>
>> > and PAR are _always_ looking at release official builds. I've been doing
>
> that
>>
>> > with CHROME_ANDROID_OFFICIAL_BUILD and did not notice the documentation
>> change.
>> > Can you please send a PSA how the documentation changed and what the
>> > plan
>
> is?
>
>> One bonus confusion: we have two internal pages referencing official
>> build,
>
> the
>>
>> instructions are slightly different.
>
>
> Sorry for any confusion. Nico mentioned that he updated the internal pages
> (see
> above) but perhaps a spot was missed?
>
> AFAIK, official build doesn't do anything differently anymore (it used to)
> from
> release build. Is that not the case?
>
> https://codereview.chromium.org/223073002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.