Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2230723004: [spv2] Do not manage effect node render surfaces from blink (Closed)

Created:
4 years, 4 months ago by pdr.
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, ajuma, trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[spv2] Do not manage effect node render surfaces from blink Render surface determination will happen on the compositor thread so we will not need to make that decision in blink/PaintArtifactCompositor. This patch switches PaintArtifactCompositor to not set the render surface bit on effect nodes. With this patch, test failures with spv2 and layer lists [1] are reduced from 1103 to 16. No new tests are included in this patch but this brings us very close to being able to turn on --enable-layer-lists by default for spv2. [1] --additional-drt-flag=--enable-slimming-paint-v2 --additional-drt-flag=--enable-layer-lists BUG=635691 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/bf1241949838e4e7f72296480087e1a3f691a89c Cr-Commit-Position: refs/heads/master@{#411248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years, 4 months ago (2016-08-10 23:46:20 UTC) #4
chrishtr
lgtm
4 years, 4 months ago (2016-08-11 00:22:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230723004/1
4 years, 4 months ago (2016-08-11 03:15:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 03:21:04 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:25:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf1241949838e4e7f72296480087e1a3f691a89c
Cr-Commit-Position: refs/heads/master@{#411248}

Powered by Google App Engine
This is Rietveld 408576698