Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2230723003: mash: Show status area widget, attempt 2 (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Show status area widget, attempt 2 * Create the widget in RootWindowController initialization * Removed unused mus version of StatusLayoutManager BUG=615155, 621112 TEST=none Committed: https://crrev.com/03c3e2fdc5e5a2a9b682e4e88a1a2e2394468ed7 Cr-Commit-Position: refs/heads/master@{#411526}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix includes #

Patch Set 4 : placeholder widget #

Total comments: 1

Patch Set 5 : Windows COM and ICU locale init #

Patch Set 6 : check icu_use_data_file, add logging #

Patch Set 7 : more logging around ICU init #

Patch Set 8 : remove ICU debugging #

Patch Set 9 : cleanup #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -141 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shelf_mus.h View 1 2 3 4 5 6 7 8 9 2 chunks +9 lines, -8 lines 0 comments Download
M ash/mus/bridge/wm_shelf_mus.cc View 1 2 3 4 5 6 7 8 9 3 chunks +18 lines, -14 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/root_window_controller.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/root_window_controller.cc View 1 2 3 4 5 6 7 8 9 5 chunks +18 lines, -7 lines 0 comments Download
D ash/mus/status_layout_manager.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ash/mus/status_layout_manager.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 39 (32 generated)
James Cook
msw, please take a look. I didn't test my previous patch after your change -- ...
4 years, 4 months ago (2016-08-10 17:06:57 UTC) #7
James Cook
Actually, hold off. This breaks mash_unittests. :-(
4 years, 4 months ago (2016-08-10 17:12:11 UTC) #8
James Cook
msw, please take a look. I had to introduce a placeholder shelf widget, as the ...
4 years, 4 months ago (2016-08-10 18:21:01 UTC) #13
msw
lgtm https://codereview.chromium.org/2230723003/diff/60001/ash/mus/bridge/wm_shelf_mus.cc File ash/mus/bridge/wm_shelf_mus.cc (right): https://codereview.chromium.org/2230723003/diff/60001/ash/mus/bridge/wm_shelf_mus.cc#newcode22 ash/mus/bridge/wm_shelf_mus.cc:22: // Create a placehold shelf widget, because the ...
4 years, 4 months ago (2016-08-10 18:37:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230723003/180001
4 years, 4 months ago (2016-08-12 01:44:36 UTC) #35
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 4 months ago (2016-08-12 02:35:25 UTC) #37
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:37:06 UTC) #39
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/03c3e2fdc5e5a2a9b682e4e88a1a2e2394468ed7
Cr-Commit-Position: refs/heads/master@{#411526}

Powered by Google App Engine
This is Rietveld 408576698