Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: build/config/mac/symbols.gni

Issue 2230723002: Make sure dSYMs are created by default for Mac sanitizer builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/symbols.gni
diff --git a/build/config/mac/symbols.gni b/build/config/mac/symbols.gni
index 8cec6955dcebda06218744ff7abd49eb3ac36db1..2cb0b8f02354ae9c4d66247f72248502a8916124 100644
--- a/build/config/mac/symbols.gni
+++ b/build/config/mac/symbols.gni
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/chrome_build.gni")
+import("//build/config/sanitizers/sanitizers.gni")
# This file declares arguments and configs that control whether dSYM debug
# info is produced and whether build products are stripped.
@@ -13,14 +14,14 @@ declare_args() {
# the //build/toolchain/mac/linker_driver.py. Enabling this will result in
# all shared library, loadable module, and executable targets having a dSYM
# generated.
- enable_dsyms = is_official_build
+ enable_dsyms = (is_official_build && is_chrome_branded) || using_sanitizer
# Strip symbols from linked targets by default. If this is enabled, the
# //build/config/mac:strip_all config will be applied to all linked targets.
- # If custom stripping paramters are required, remove that config from a
+ # If custom stripping parameters are required, remove that config from a
# linked target and apply custom -Wcrl,strip flags. See
# //build/toolchain/mac/linker_driver.py for more information.
- enable_stripping = is_official_build
+ enable_stripping = is_official_build && is_chrome_branded
}
# Save unstripped copies of targets with a ".unstripped" suffix. This is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698