Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2230713005: Guard against re-entrant requests for stack traces. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against re-entrant requests for stack traces. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/0ad1b4e9235029433ba0a5422cd4510f65c340b5

Patch Set 1 #

Total comments: 2

Patch Set 2 : atomic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/vm/profiler.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-10 17:43:59 UTC) #2
zra
https://codereview.chromium.org/2230713005/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/2230713005/diff/1/runtime/vm/profiler.cc#newcode953 runtime/vm/profiler.cc:953: static bool started_dump = false; It probably doesn't matter ...
4 years, 4 months ago (2016-08-10 17:52:27 UTC) #3
rmacnak
https://codereview.chromium.org/2230713005/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/2230713005/diff/1/runtime/vm/profiler.cc#newcode953 runtime/vm/profiler.cc:953: static bool started_dump = false; On 2016/08/10 17:52:27, zra ...
4 years, 4 months ago (2016-08-11 00:08:02 UTC) #4
zra
lgtm
4 years, 4 months ago (2016-08-11 14:48:22 UTC) #5
rmacnak
4 years, 4 months ago (2016-08-11 16:46:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0ad1b4e9235029433ba0a5422cd4510f65c340b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698