Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2230713004: Update the QUIC compressed cert set. (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Buck, Paweł Hajdan Jr.
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the QUIC compressed cert set. BUG=636423 Committed: https://crrev.com/34ac40cd2060d4e4eeecaa9b653e3f89da444430 Cr-Commit-Position: refs/heads/master@{#411395}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4627 lines, -5124 lines) Patch
M net/quic/core/crypto/common_cert_set.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A + net/quic/core/crypto/common_cert_set_3.c View 1 3 chunks +19 lines, -25 lines 0 comments Download
A + net/quic/core/crypto/common_cert_set_3a.inc View 1 2 29 chunks +1721 lines, -2310 lines 0 comments Download
A + net/quic/core/crypto/common_cert_set_3b.inc View 1 2 25 chunks +2767 lines, -2789 lines 0 comments Download
M net/quic/core/crypto/common_cert_set_test.cc View 2 chunks +109 lines, -0 lines 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
Ryan Hamilton
PTAL
4 years, 4 months ago (2016-08-10 16:28:57 UTC) #2
Buck
lgtm
4 years, 4 months ago (2016-08-10 16:41:19 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 4 months ago (2016-08-10 16:54:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230713004/1
4 years, 4 months ago (2016-08-10 16:55:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/205245) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 17:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230713004/20001
4 years, 4 months ago (2016-08-10 18:12:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/277738)
4 years, 4 months ago (2016-08-10 20:12:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230713004/40001
4 years, 4 months ago (2016-08-10 20:48:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120335)
4 years, 4 months ago (2016-08-11 01:05:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230713004/40001
4 years, 4 months ago (2016-08-11 17:16:56 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120913)
4 years, 4 months ago (2016-08-11 18:12:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230713004/40001
4 years, 4 months ago (2016-08-11 18:33:03 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 19:16:25 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:18:27 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34ac40cd2060d4e4eeecaa9b653e3f89da444430
Cr-Commit-Position: refs/heads/master@{#411395}

Powered by Google App Engine
This is Rietveld 408576698