Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2230683003: [LayoutNG] Initial implementation of NGBoxIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
index 06db39bc78734a7021194fb1e9bc0da2b4a9ed9d..8db38b08a5473c8cffb56d35143e4709c54bc16c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
@@ -6,6 +6,7 @@
#define NGBlockLayoutAlgorithm_h
#include "core/layout/ng/ng_box.h"
+#include "core/layout/ng/ng_box_iterator.h"
#include "wtf/RefPtr.h"
namespace blink {
@@ -18,7 +19,7 @@ class NGFragment;
// Lays out the children in sequence.
class NGBlockLayoutAlgorithm {
public:
- NGBlockLayoutAlgorithm(PassRefPtr<const ComputedStyle>, NGBox);
+ NGBlockLayoutAlgorithm(PassRefPtr<const ComputedStyle>, NGBoxIterator);
cbiesinger 2016/08/10 19:55:24 Can you add a comment saying that the iterator is
Gleb Lanbin 2016/08/10 20:11:44 Done.
// Actual layout implementation. Lays out the children in sequence within the
// constraints given by the NGConstraintSpace. Returns a fragment with the
@@ -29,7 +30,7 @@ class NGBlockLayoutAlgorithm {
private:
RefPtr<const ComputedStyle> m_style;
- NGBox m_firstChild;
+ NGBoxIterator m_ngBoxIterator;
cbiesinger 2016/08/10 19:55:24 I'd rather us not put the "ng" in the variable nam
eae 2016/08/10 19:59:32 agreed. boxIterator will do.
Gleb Lanbin 2016/08/10 20:11:44 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698