[LayoutNG] Initial implementation of NGBoxIterator

[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619
Committed: https://crrev.com/8ba5761a1d6c8f1dc7f972b75487205bfb530256
Cr-Commit-Position: refs/heads/master@{#411263}

[Gleb Lanbin, 2016-08-10 18:52:06]

Description was changed from

==========
Initial implementaion of NGBoxIterator

BUG=
==========

to

==========
[LayoutNG] Initial implementation of NGBoxIterator

BUG=635619
==========

[Gleb Lanbin, 2016-08-10 18:54:06]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2016-08-10 19:46:59]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org

[ikilpatrick, 2016-08-10 19:46:59]

lgtm

[cbiesinger, 2016-08-10 19:55:24]

lgtm

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
(right):

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:22:
NGBlockLayoutAlgorithm(PassRefPtr<const ComputedStyle>, NGBoxIterator);
Can you add a comment saying that the iterator is for the children of this
algorithm?

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:33:
NGBoxIterator m_ngBoxIterator;
I'd rather us not put the "ng" in the variable name

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h (right):

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h:14: class
NGBoxIterator {
Can you add a comment saying that this will iterator over the siblings of the
layout object?

[eae, 2016-08-10 19:59:32]

LGTM

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
(right):

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:33:
NGBoxIterator m_ngBoxIterator;
On 2016/08/10 19:55:24, cbiesinger wrote:
> I'd rather us not put the "ng" in the variable name

agreed. boxIterator will do.

[Gleb Lanbin, 2016-08-10 20:11:44]

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
(right):

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:22:
NGBlockLayoutAlgorithm(PassRefPtr<const ComputedStyle>, NGBoxIterator);
On 2016/08/10 19:55:24, cbiesinger wrote:
> Can you add a comment saying that the iterator is for the children of this
> algorithm?

Done.

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:33:
NGBoxIterator m_ngBoxIterator;
On 2016/08/10 19:59:32, eae wrote:
> On 2016/08/10 19:55:24, cbiesinger wrote:
> > I'd rather us not put the "ng" in the variable name
> 
> agreed. boxIterator will do.

Done.

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h (right):

https://codereview.chromium.org/2230683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_box_iterator.h:14: class
NGBoxIterator {
On 2016/08/10 19:55:24, cbiesinger wrote:
> Can you add a comment saying that this will iterator over the siblings of the
> layout object?

Done.

[cbiesinger, 2016-08-10 20:14:26]

lgtm

[Gleb Lanbin, 2016-08-10 21:22:10]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-08-10 21:22:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org, cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2230683003/#ps40001
(title: "synced to the head")

[commit-bot: I haz the power, 2016-08-10 21:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 01:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:03:43]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Gleb Lanbin, 2016-08-11 03:27:31]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:33:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Gleb Lanbin, 2016-08-11 04:13:51]

Description was changed from

==========
[LayoutNG] Initial implementation of NGBoxIterator

BUG=635619
==========

to

==========
[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619
==========

[Gleb Lanbin, 2016-08-11 04:13:56]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-08-11 04:13:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2230683003/#ps60001
(title: "synced to the head")

[commit-bot: I haz the power, 2016-08-11 04:14:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:18:01]

Description was changed from

==========
[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619
==========

to

==========
[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619
==========

[commit-bot: I haz the power, 2016-08-11 04:18:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-11 04:20:27]

Description was changed from

==========
[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619
==========

to

==========
[LayoutNG] Initial implementation of NGBoxIterator

NOTRY=true
BUG=635619

Committed: https://crrev.com/8ba5761a1d6c8f1dc7f972b75487205bfb530256
Cr-Commit-Position: refs/heads/master@{#411263}
==========

[commit-bot: I haz the power, 2016-08-11 04:20:29]

Patchset 4 (id:??) landed as
https://crrev.com/8ba5761a1d6c8f1dc7f972b75487205bfb530256
Cr-Commit-Position: refs/heads/master@{#411263}

[samli, 2016-08-11 04:34:01]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2234263002/ by samli@chromium.org.

The reason for reverting is: Fails to compile.

Why was NOTRY=true used? CQ indicated an error..

[findit-for-me, 2016-08-11 04:37:54]

FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 411263 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...