Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2230643002: Use StringView for String::findIgnoringCase and findIgnoringASCIICase. (Closed)

Created:
4 years, 4 months ago by esprehn
Modified:
4 years, 4 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringView for String::findIgnoringCase and findIgnoringASCIICase. StringImpl's version of this already takes a StringView, but the proxy functions on String took a const String& so callers like didFireWebGLErrorOrWarning doing message.findIgnoringCase("error") were allocating temporary strings. Instead we make the String methods take a StringView too to avoid the extra allocations. I also added these methods to AtomicString so the API is the same. BUG=615174 Committed: https://crrev.com/c34b20c196d32daae5764098479936bc7e10e61f Cr-Commit-Position: refs/heads/master@{#410973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
esprehn
4 years, 4 months ago (2016-08-09 22:38:33 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-10 00:58:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230643002/1
4 years, 4 months ago (2016-08-10 01:02:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 05:53:40 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 05:55:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c34b20c196d32daae5764098479936bc7e10e61f
Cr-Commit-Position: refs/heads/master@{#410973}

Powered by Google App Engine
This is Rietveld 408576698