[Offline pages] Downloads UI: Extening DownloadSharedPreferenceEntry to include offline page

[Offline pages] Downloads UI: Extening DownloadSharedPreferenceEntry to include offline page

Introduces DownloadSharedPreferenceEntry version 3, which:
* Adds item type to distinguish between offline page and download
* Introduces more tests for parsing and serialization
* Moves tests to jUnit.

BUG=630817
Committed: https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc
Cr-Commit-Position: refs/heads/master@{#411185}

[fgorski, 2016-08-09 22:14:56]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org, qinmin@chromium.org

[fgorski, 2016-08-09 22:14:56]

Hi, Min, I am trying to get the notifications ready for offline pages. I believe
we will need to distinguish the two when keeping in shared preference entry.
PTAL and let me know what you think.

[fgorski, 2016-08-09 22:15:03]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 22:15:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2016-08-09 22:48:48]

lgtm % nit

https://codereview.chromium.org/2230603003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2230603003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:72:
int currentIndex = 1, id = 0, itemType = ITEM_TYPE_DOWNLOAD;
use separate lines for this

[commit-bot: I haz the power, 2016-08-09 23:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:41:27]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-10 16:48:15]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-10 17:01:17]

Updated.

https://codereview.chromium.org/2230603003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2230603003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:72:
int currentIndex = 1, id = 0, itemType = ITEM_TYPE_DOWNLOAD;
On 2016/08/09 22:48:48, qinmin wrote:
> use separate lines for this

Done.

[commit-bot: I haz the power, 2016-08-10 18:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:28:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Dmitry Titov, 2016-08-10 18:34:04]

lgtm

[fgorski, 2016-08-10 18:38:50]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-08-10 18:38:53]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2230603003/#ps40001
(title: "Fixing the test for invalid version and version check")

[commit-bot: I haz the power, 2016-08-10 18:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:48:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fgorski, 2016-08-10 20:05:51]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 20:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-10 20:06:55]

fgorski@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[fgorski, 2016-08-10 20:06:56]

dfalcantara@chromium.org: We need the ownership stamp for the junit portion,
please.

Thanks.

[gone, 2016-08-10 20:11:57]

rs lgtm

[commit-bot: I haz the power, 2016-08-10 22:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:43:34]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-10 23:22:32]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-08-10 23:22:33]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2230603003/#ps60001
(title: "Adding OWNERS file to the tests")

[commit-bot: I haz the power, 2016-08-10 23:23:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:37:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-10 23:39:59]

Description was changed from

==========
[Offline pages] Downloads UI: Extening DownloadSharedPreferenceEntry to include
offline page

Introduces DownloadSharedPreferenceEntry version 3, which:
* Adds item type to distinguish between offline page and download
* Introduces more tests for parsing and serialization
* Moves tests to jUnit.

BUG=630817
==========

to

==========
[Offline pages] Downloads UI: Extening DownloadSharedPreferenceEntry to include
offline page

Introduces DownloadSharedPreferenceEntry version 3, which:
* Adds item type to distinguish between offline page and download
* Introduces more tests for parsing and serialization
* Moves tests to jUnit.

BUG=630817

Committed: https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc
Cr-Commit-Position: refs/heads/master@{#411185}
==========

[commit-bot: I haz the power, 2016-08-10 23:40:00]

Patchset 4 (id:??) landed as
https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc
Cr-Commit-Position: refs/heads/master@{#411185}