CSS filters: fix filtered parent with composited, transformed child.

CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394, 618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f
Cr-Commit-Position: refs/heads/master@{#411432}

[Stephen White, 2016-08-09 19:34:53]

Description was changed from

==========
CSS filters: fix filtered parent and composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
==========

to

==========
CSS filters: fix filtered parent and composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
==========

[Stephen White, 2016-08-09 19:34:53]

senorblanco@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Stephen White, 2016-08-09 19:36:00]

chrishtr@: PTAL.

I'm open to new names for AlwaysIncludeTransforms, if you
don't like it. Or different approaches.

[Stephen White, 2016-08-09 19:36:10]

Description was changed from

==========
CSS filters: fix filtered parent and composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
==========

to

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
==========

[Stephen White, 2016-08-09 19:36:15]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen White, 2016-08-09 20:39:47]

Note: this fixes the given case (with a static composited child), But it doesn't
fix the general case of an animated composited child, e.g.,
https://jsfiddle.net/6hqrwbqa/

In that case, the animation is handled entirely cc-side (AFAIK), and
FilterEffectBuilder::buildReferenceFilter() never gets called, so the reference
box is never re-computed. When the animation stops,
FilterEffectBuilder::buildReferenceFilter() is called, and the reference box is
updated.

Not sure how to fix the more general problem.

[commit-bot: I haz the power, 2016-08-09 21:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:20:04]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-08-10 21:36:16]

https://codereview.chromium.org/2230593002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.h (right):

https://codereview.chromium.org/2230593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.h:363: AlwaysIncludeTransforms,
IncludeTransformsAndcompositedchildLayesr

[Stephen White, 2016-08-11 14:26:37]

Description was changed from

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
==========

to

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Stephen White, 2016-08-11 14:31:45]

Fixed per comments.

Also added fix from https://codereview.chromium.org/2232013002/ to accommodate
negatively transformed child, and added test case.

https://codereview.chromium.org/2230593002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.h (right):

https://codereview.chromium.org/2230593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.h:363: AlwaysIncludeTransforms,
On 2016/08/10 21:36:16, chrishtr wrote:
> IncludeTransformsAndcompositedchildLayesr

Done.

[Stephen White, 2016-08-11 14:59:12]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 14:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen White, 2016-08-11 19:12:07]

Description was changed from

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394,618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-08-11 19:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:18:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Stephen White, 2016-08-11 19:22:01]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:22:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:29:08]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-08-11 22:42:01]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-08-11 22:42:01]

lgtm

[commit-bot: I haz the power, 2016-08-11 22:43:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:48:01]

Description was changed from

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394,618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394,618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-08-11 22:48:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-11 22:50:44]

Description was changed from

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394,618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG=620394,618642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f
Cr-Commit-Position: refs/heads/master@{#411432}
==========

[commit-bot: I haz the power, 2016-08-11 22:50:45]

Patchset 4 (id:??) landed as
https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f
Cr-Commit-Position: refs/heads/master@{#411432}