[LayoutNG] Very simple layout() implementation

[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/7872d0ed57157601145d7efe6f3c773750f38ee2
Cr-Commit-Position: refs/heads/master@{#410814}

[cbiesinger, 2016-08-09 18:42:58]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:43:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-09 18:51:49]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-09 18:57:21]

Description was changed from

==========
[layoutng] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
==========

[eae, 2016-08-09 18:58:04]

LGTM w/nit

https://codereview.chromium.org/2230563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.h (right):

https://codereview.chromium.org/2230563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.h:19:
NGBlockLayoutAlgorithm(ComputedStyle*);
const?

[eae, 2016-08-09 19:14:54]

LGTM

[Gleb Lanbin, 2016-08-09 19:16:16]

lgtm

[cbiesinger, 2016-08-09 19:31:24]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:33:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-09 19:54:28]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-09 20:34:02]

Description was changed from

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

[cbiesinger, 2016-08-09 20:34:09]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-08-09 20:34:14]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-08-09 20:34:15]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2230563002/#ps60001
(title: "Update per NGFragment change")

[commit-bot: I haz the power, 2016-08-09 20:34:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:38:34]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp:6
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp' with
conflicts.
  U third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp

Patch:       third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
Index: third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
diff --git a/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
b/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
index
b7d4b998524e729517dfe869f1d7154d4d09c63e..8f61d24481e0c4a058ea0949fc2e550d1c738063
100644
--- a/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
+++ b/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp
@@ -6,14 +6,27 @@
 
 #include "core/layout/LayoutBox.h"
 #include "core/layout/ng/NGConstraintSpace.h"
+#include "core/layout/ng/NGFragment.h"
 #include "core/style/ComputedStyle.h"
+#include "platform/LengthFunctions.h"
 
 namespace blink {
 
-NGBlockLayoutAlgorithm::NGBlockLayoutAlgorithm()
+NGBlockLayoutAlgorithm::NGBlockLayoutAlgorithm(const ComputedStyle* style)
+    : m_style(style)
 {
 }
 
+NGFragment* NGBlockLayoutAlgorithm::layout(
+    const NGConstraintSpace& constraintSpace)
+{
+    LayoutUnit inlineSize = valueForLength(m_style->logicalWidth(),
+        constraintSpace.inlineContainerSize());
+    LayoutUnit blockSize = valueForLength(m_style->logicalHeight(),
+        constraintSpace.blockContainerSize());
+    return new NGFragment(inlineSize, blockSize, inlineSize, blockSize);
+}
+
 NGConstraintSpace
NGBlockLayoutAlgorithm::createConstraintSpaceFromLayoutObject(const LayoutBox&
child)
 {
     bool fixedInline = false, fixedBlock = false;

[cbiesinger, 2016-08-09 20:49:12]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-08-09 20:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2230563002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-09 20:49:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:54:59]

Description was changed from

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-09 20:55:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-09 20:57:13]

Description was changed from

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[LayoutNG] Very simple layout() implementation

Just resolved width and height, and returns a fragment with that.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/7872d0ed57157601145d7efe6f3c773750f38ee2
Cr-Commit-Position: refs/heads/master@{#410814}
==========

[commit-bot: I haz the power, 2016-08-09 20:57:14]

Patchset 5 (id:??) landed as
https://crrev.com/7872d0ed57157601145d7efe6f3c773750f38ee2
Cr-Commit-Position: refs/heads/master@{#410814}