Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2230543002: Change the test "TrackTextSelectionForAllFrames" to actually run on an OOPIF page. (Closed)

Created:
4 years, 4 months ago by EhsanK
Modified:
4 years, 4 months ago
Reviewers:
kenrb, Charlie Reis, nasko
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the test "TrackTextSelectionForAllFrames" to actually run on an OOPIF page. This CL changes the test a bit so that it will run on a test page with several <iframe>s ([out-of|in]-process). BUG=578168, 602723 using select() to simulate the chagne Committed: https://crrev.com/af4343904a4f27311c19dcb28249937cc3c10d17 Cr-Commit-Position: refs/heads/master@{#410808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -27 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 3 chunks +45 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
EhsanK
PTAL.
4 years, 4 months ago (2016-08-09 18:34:22 UTC) #4
Charlie Reis
LGTM
4 years, 4 months ago (2016-08-09 20:40:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230543002/1
4 years, 4 months ago (2016-08-09 20:41:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:46:30 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:49:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af4343904a4f27311c19dcb28249937cc3c10d17
Cr-Commit-Position: refs/heads/master@{#410808}

Powered by Google App Engine
This is Rietveld 408576698