Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2230533002: Delete dead consumer enrollment code. (Closed)

Created:
4 years, 4 months ago by Thiemo Nagel
Modified:
4 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete dead consumer enrollment code. BUG=636318 TBR=oshima CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38 Cr-Commit-Position: refs/heads/master@{#411592}

Patch Set 1 #

Patch Set 2 : More stuff to delete. #

Patch Set 3 : Delete a bit more. #

Patch Set 4 : Fix closure compilation error. #

Patch Set 5 : Fix CloudPolicyConstantsTest. #

Patch Set 6 : Fix Chrome OS tests. #

Patch Set 7 : Remove ManagementMode. #

Patch Set 8 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -3662 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 6 7 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/consumer_management_notification_icon.png View 1 2 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/cros/consumer_management_notification_icon.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/fake_owner_settings_service.h View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ownership/fake_owner_settings_service.cc View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 1 2 3 4 5 6 5 chunks +4 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 2 3 4 5 6 8 chunks +2 lines, -86 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -122 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h View 1 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 1 7 chunks +0 lines, -47 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler_factory.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler_factory.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler_factory_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier.cc View 1 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier_factory.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier_factory.cc View 1 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier_factory_unittest.cc View 1 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc View 1 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_service.h View 1 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_service.cc View 1 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_service_unittest.cc View 1 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_stage.h View 1 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_management_stage.cc View 1 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc View 1 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc View 1 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc View 1 1 chunk +0 lines, -127 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.h View 1 2 3 4 5 6 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 2 3 4 5 6 5 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 2 3 4 5 6 8 chunks +7 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 2 3 4 5 6 2 chunks +31 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 1 2 3 4 5 6 3 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.h View 1 2 3 4 5 6 5 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 1 2 3 4 5 6 7 chunks +10 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/policy/fake_consumer_management_service.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/chromeos/policy/fake_consumer_management_service.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 2 3 4 5 6 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 5 6 7 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 5 6 7 2 chunks +0 lines, -47 lines 0 comments Download
D chrome/browser/resources/options/chromeos/consumer_management_overlay.css View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/options/chromeos/consumer_management_overlay.html View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/resources/options/chromeos/consumer_management_overlay.js View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 3 4 5 6 7 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 7 5 chunks +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/consumer_management_handler.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/consumer_management_handler.cc View 1 1 chunk +0 lines, -112 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.h View 1 2 3 4 5 6 1 chunk +0 lines, -21 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.cc View 1 2 3 4 5 6 1 chunk +0 lines, -39 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 60 (41 generated)
Thiemo Nagel
Hi David, this code looks unused. Do you have objections against deleting it? Thank you! ...
4 years, 4 months ago (2016-08-09 16:10:58 UTC) #4
davidyu
On 2016/08/09 16:10:58, Thiemo Nagel wrote: > Hi David, > > this code looks unused. ...
4 years, 4 months ago (2016-08-09 19:40:08 UTC) #7
Thiemo Nagel
Hi Sasha, could you please take a look at */policy/*? Thank you! Thiemo
4 years, 4 months ago (2016-08-10 11:10:59 UTC) #15
Thiemo Nagel
Hi Dan, may I kindly ask you to take a look at chrome/browser/ui and chrome/browser/resources? ...
4 years, 4 months ago (2016-08-10 11:16:56 UTC) #20
peletskyi
On 2016/08/10 11:10:59, Thiemo Nagel wrote: > Hi Sasha, > > could you please take ...
4 years, 4 months ago (2016-08-10 15:16:56 UTC) #35
Dan Beam
\o/ lgtm
4 years, 4 months ago (2016-08-10 19:29:03 UTC) #36
Thiemo Nagel
Hi Mitsuru, could you please take a look at chrome/app/theme and chrome/browser/chromeos? Thank you! Thiemo
4 years, 4 months ago (2016-08-11 09:03:11 UTC) #38
Thiemo Nagel
Hi Jochen, could you please take a look at chrome/browser/BUILD.gn chrome/browser/prefs/browser_prefs.cc chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc? Thank you, Thiemo
4 years, 4 months ago (2016-08-11 09:07:45 UTC) #40
Thiemo Nagel
On 2016/08/11 09:07:45, Thiemo Nagel wrote: > Hi Jochen, > > could you please take ...
4 years, 4 months ago (2016-08-11 09:09:33 UTC) #41
Thiemo Nagel
Hi Bernhard, could you please take a look at chrome/browser/prefs/browser_prefs.cc? Thank you, Thiemo
4 years, 4 months ago (2016-08-11 09:14:47 UTC) #44
Thiemo Nagel
Hi Elliot, could you please take a look at chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc? Thank you! Thiemo
4 years, 4 months ago (2016-08-11 09:16:41 UTC) #46
Thiemo Nagel
Hi Andrew, could you please take a look at chrome/browser/BUILD.gn? Thank you! Thiemo
4 years, 4 months ago (2016-08-11 09:18:47 UTC) #48
Bernhard Bauer
On 2016/08/10 11:16:56, Thiemo Nagel wrote: > Hi Dan, > > may I kindly ask ...
4 years, 4 months ago (2016-08-11 10:25:29 UTC) #49
Thiemo Nagel
On 2016/08/11 10:25:29, Bernhard Bauer wrote: > On 2016/08/10 11:16:56, Thiemo Nagel wrote: > > ...
4 years, 4 months ago (2016-08-11 10:38:30 UTC) #50
agrieve
BUILD.gn lgtm
4 years, 4 months ago (2016-08-11 14:12:00 UTC) #51
Elliot Glaysher
profiles lgtm
4 years, 4 months ago (2016-08-11 17:17:35 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230533002/130001
4 years, 4 months ago (2016-08-12 09:52:27 UTC) #56
commit-bot: I haz the power
Committed patchset #8 (id:130001)
4 years, 4 months ago (2016-08-12 10:47:00 UTC) #58
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 10:48:47 UTC) #60
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/ae5ce60dc9addb27383cce094b98c951753d0f38
Cr-Commit-Position: refs/heads/master@{#411592}

Powered by Google App Engine
This is Rietveld 408576698