Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: tests/lib/convert/json_lib_test.dart

Issue 223053004: lib/convert: removed unused import, removed redundant test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: removed status file entry Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/convert/json2_test.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/convert/json_lib_test.dart
diff --git a/tests/lib/convert/json_lib_test.dart b/tests/lib/convert/json_lib_test.dart
index f820273921f213d2852f8c54e6cb60cfc3801259..1226f7bb907276c1af0b997f97f62f1d43b7538e 100644
--- a/tests/lib/convert/json_lib_test.dart
+++ b/tests/lib/convert/json_lib_test.dart
@@ -81,9 +81,8 @@ main() {
expect(JSON.encode(null), equals('null'));
expect(JSON.encode(' hi there" bob '), equals('" hi there\\" bob "'));
expect(JSON.encode('hi\\there'), equals('"hi\\\\there"'));
- // TODO(devoncarew): these tests break the dartium build
ricow1 2014/04/03 05:29:22 Devon: is there a bug for this that we can close o
devoncarew 2014/04/03 07:24:28 Sorry, no. This comment dates back to when I start
- //expect(JSON.encode('hi\nthere'), equals('"hi\\nthere"'));
- //expect(JSON.encode('hi\r\nthere'), equals('"hi\\r\\nthere"'));
+ expect(JSON.encode('hi\nthere'), equals('"hi\\nthere"'));
+ expect(JSON.encode('hi\r\nthere'), equals('"hi\\r\\nthere"'));
expect(JSON.encode(''), equals('""'));
// Lists.
« no previous file with comments | « tests/lib/convert/json2_test.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698