Issue 223053002: Have depot_tools manpage generation pin asciidoc version too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223053002: Have depot_tools manpage generation pin asciidoc version too. (Closed)

Created:
6 years, 8 months ago by iannucci

Modified:
6 years, 8 months ago

Reviewers:
ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Have depot_tools manpage generation pin asciidoc version too. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=261235

Patch Set 3 : address comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	docs/src/.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	docs/src/make_docs.sh	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ghost stip (do not use)

lgtm w/ question https://chromiumcodereview.appspot.com/223053002/diff/20001/docs/src/make_docs.sh File docs/src/make_docs.sh (left): https://chromiumcodereview.appspot.com/223053002/diff/20001/docs/src/make_docs.sh#oldcode35 docs/src/make_docs.sh:35: GITHASH=5f95c9f850b19b368c43ae399cc831b17a26a5ac why not leave this at ...

6 years, 8 months ago (2014-04-02 23:04:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/223053002/40001

6 years, 8 months ago (2014-04-03 00:07:56 UTC) #3

Message was sent while issue was closed.

Change committed as 261235

Expand Messages | Collapse Messages

Issue 223053002: Have depot_tools manpage generation pin asciidoc version too. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : address comment #

Messages