Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: third_party/WebKit/public/platform/WebDisplayItemList.h

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebDisplayItemList.h
diff --git a/third_party/WebKit/public/platform/WebDisplayItemList.h b/third_party/WebKit/public/platform/WebDisplayItemList.h
index 91659e005365d1254fafb2d7b59f3d636baba72c..2342edbeb17c14ef9d374bd94b106a7f12e85188 100644
--- a/third_party/WebKit/public/platform/WebDisplayItemList.h
+++ b/third_party/WebKit/public/platform/WebDisplayItemList.h
@@ -39,26 +39,26 @@ public:
virtual void appendDrawingItem(const WebRect& visualRect, sk_sp<const SkPicture>) { }
- virtual void appendClipItem(const WebRect& visualRect, const WebRect& clipRect, const WebVector<SkRRect>& roundedClipRects) { }
- virtual void appendEndClipItem(const WebRect& visualRect) { }
- virtual void appendClipPathItem(const WebRect& visualRect, const SkPath&, SkRegion::Op, bool antialias) { }
- virtual void appendEndClipPathItem(const WebRect& visualRect) { }
- virtual void appendFloatClipItem(const WebRect& visualRect, const WebFloatRect& clipRect) { }
- virtual void appendEndFloatClipItem(const WebRect& visualRect) { }
- virtual void appendTransformItem(const WebRect& visualRect, const SkMatrix44&) { }
- virtual void appendEndTransformItem(const WebRect& visualRect) { }
- virtual void appendCompositingItem(const WebRect& visualRect, float opacity,
+ virtual void appendClipItem(const WebRect& clipRect, const WebVector<SkRRect>& roundedClipRects) { }
+ virtual void appendEndClipItem() { }
+ virtual void appendClipPathItem(const SkPath&, SkRegion::Op, bool antialias) { }
+ virtual void appendEndClipPathItem() { }
+ virtual void appendFloatClipItem(const WebFloatRect& clipRect) { }
+ virtual void appendEndFloatClipItem() { }
+ virtual void appendTransformItem(const SkMatrix44&) { }
+ virtual void appendEndTransformItem() { }
+ virtual void appendCompositingItem(float opacity,
SkXfermode::Mode, SkRect* bounds, SkColorFilter*) { }
- virtual void appendEndCompositingItem(const WebRect& visualRect) { }
+ virtual void appendEndCompositingItem() { }
// TODO(loyso): This should use CompositorFilterOperation. crbug.com/584551
- virtual void appendFilterItem(const WebRect& visualRect, const cc::FilterOperations&, const WebFloatRect& bounds) { }
- virtual void appendEndFilterItem(const WebRect& visualRect) { }
+ virtual void appendFilterItem(const cc::FilterOperations&, const WebFloatRect& bounds) { }
+ virtual void appendEndFilterItem() { }
// Scroll containers are identified by an opaque pointer.
using ScrollContainerId = const void*;
- virtual void appendScrollItem(const WebRect& visualRect, const WebSize& scrollOffset, ScrollContainerId) { }
- virtual void appendEndScrollItem(const WebRect& visualRect) { }
+ virtual void appendScrollItem(const WebSize& scrollOffset, ScrollContainerId) { }
+ virtual void appendEndScrollItem() { }
virtual void setIsSuitableForGpuRasterization(bool isSuitable) { }
};
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp ('k') | ui/compositor/clip_recorder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698