cc/trees/layer_tree_host_pixeltest_masks.cc - Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_pixeltest_masks.cc

Issue 2230513005: Move visual rect unioning between paired items to cc::DisplayItemList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_pixeltest_masks.cc

diff --git a/cc/trees/layer_tree_host_pixeltest_masks.cc b/cc/trees/layer_tree_host_pixeltest_masks.cc

index d991b6446786d6f3a410048e890c1a96cbd75b2d..3d63cda328f4afb5771769adfca410f9d8a39ae9 100644

--- a/cc/trees/layer_tree_host_pixeltest_masks.cc

+++ b/cc/trees/layer_tree_host_pixeltest_masks.cc

@@ -61,7 +61,7 @@ class MaskContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

- display_list->CreateAndAppendItem<DrawingDisplayItem>(

+ display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(

PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

@@ -361,7 +361,7 @@ class CheckerContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

- display_list->CreateAndAppendItem<DrawingDisplayItem>(

+ display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(

PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

@@ -399,7 +399,7 @@ class CircleContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

- display_list->CreateAndAppendItem<DrawingDisplayItem>(

+ display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(

PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

« no previous file with comments | « cc/test/solid_color_content_layer_client.cc ('k') | cc/trees/layer_tree_host_pixeltest_tiles.cc » ('j') | no next file with comments »