Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.html

Issue 2230513003: [MD settings] setup site settings menus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_list.html
diff --git a/chrome/browser/resources/settings/site_settings/site_list.html b/chrome/browser/resources/settings/site_settings/site_list.html
index 9a2e67e7ceb29fc29e346166c2e15508e02708ce..a8a6edf7b6aaa5cb33f99de5b243ce86a745379c 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.html
+++ b/chrome/browser/resources/settings/site_settings/site_list.html
@@ -66,36 +66,33 @@
<template is="dom-if" if="[[isPolicyControlled_(item.source)]]">
<iron-icon icon="cr:domain"></iron-icon>
</template>
- <template is="dom-if" if="[[shouldShowMenu_(item.source)]]">
- <paper-menu-button>
- <paper-icon-button icon="cr:more-vert"
- class="dropdown-trigger">
- </paper-icon-button>
- <paper-menu id="actionMenu" class="dropdown-content"
- on-iron-activate="onActionMenuIronActivate_"
- attr-for-selected="menu-value">
- <paper-item
- hidden="[[!showAllowAction_]]"
- menu-value$="[[PermissionValues.ALLOW]]">
- $i18n{siteSettingsActionAllow}
- </paper-item>
- <paper-item
- hidden="[[!showBlockAction_]]"
- menu-value$="[[PermissionValues.BLOCK]]">
- $i18n{siteSettingsActionBlock}
- </paper-item>
- <paper-item
- hidden="[[!showSessionOnlyAction_]]"
- menu-value$="[[PermissionValues.SESSION_ONLY]]">
- $i18n{siteSettingsActionSessionOnly}
- </paper-item>
- <paper-item
- menu-value$="[[PermissionValues.DEFAULT]]">
- $i18n{siteSettingsActionReset}
- </paper-item>
- </paper-menu>
- </paper-menu-button>
- </template>
+ <paper-menu-button hidden="[[!shouldShowMenu_(item.source)]]">
+ <paper-icon-button icon="cr:more-vert" class="dropdown-trigger">
+ </paper-icon-button>
+ <paper-menu id="actionMenu" class="dropdown-content"
+ on-iron-activate="onActionMenuIronActivate_"
+ attr-for-selected="menu-value">
+ <paper-item
+ hidden="[[!showAllowAction_]]"
+ menu-value$="[[PermissionValues.ALLOW]]">
+ $i18n{siteSettingsActionAllow}
+ </paper-item>
+ <paper-item
+ hidden="[[!showBlockAction_]]"
+ menu-value$="[[PermissionValues.BLOCK]]">
+ $i18n{siteSettingsActionBlock}
+ </paper-item>
+ <paper-item
+ hidden="[[!showSessionOnlyAction_]]"
+ menu-value$="[[PermissionValues.SESSION_ONLY]]">
+ $i18n{siteSettingsActionSessionOnly}
+ </paper-item>
+ <paper-item
+ menu-value$="[[PermissionValues.DEFAULT]]">
+ $i18n{siteSettingsActionReset}
+ </paper-item>
+ </paper-menu>
+ </paper-menu-button>
</div>
</template>
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698