[MD settings] setup site settings menus

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   function registerTests() {
     suite('SiteList', function() {
       /**
        * A site list element created before each test.
@@ skipping 250 matching lines @@
       // Initialize a site-list before each test.
       setup(function() {
         browserProxy = new TestSiteSettingsPrefsBrowserProxy();
         settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
         PolymerTest.clearBody();
         testElement = document.createElement('settings-site-list');
         document.body.appendChild(testElement);
       });
 
       /**
+       * Fetch the non-hidden menu items from the list.
+       * @param {!HTMLElement} parentElement
+       */
+      function getMenuItems(listContainer) {
+        return listContainer.children[0].querySelectorAll(
+            'paper-menu-button paper-item:not([hidden])');
+      }
+
+      /**
        * Asserts the menu looks as expected.
        * @param {Array<string>} items The items expected to show in the menu.
        * @param {!HTMLElement} parentElement The parent node to start looking
        *     in.
        */
       function assertMenu(items, parentElement) {
-        var listItem = parentElement.$.listContainer.children[0];
-        var menuItems = listItem.querySelectorAll(
-            'paper-menu-button paper-item:not([hidden])');
+        var menuItems = getMenuItems(parentElement.$.listContainer);
         assertEquals(items.length, menuItems.length);
         for (var i = 0; i < items.length; i++)
           assertEquals(items[i], menuItems[i].textContent.trim());
       }
 
       /**
        * Configures the test element for a particular category.
        * @param {settings.ContentSettingsTypes} category The category to setup.
        * @param {settings.PermissionValues} subtype Type of list to use.
        * @param {Array<dictionary>} prefs The prefs to use.
@@ skipping 344 matching lines @@
 
       test('Mixed schemes (present and absent)', function() {
         // Prefs: One item with scheme and one without.
         setupCategory(settings.ContentSettingsTypes.GEOLOCATION,
             settings.PermissionValues.ALLOW, prefsMixedSchemes);
         return browserProxy.whenCalled('getExceptionList').then(
             function(contentType) {
               // No further checks needed. If this fails, it will hang the test.
             });
       });
+
+      test('Select menu item', function() {
+        // Test for error:
+        //   "Cannot read property 'origin' of undefined"
+        // which occurs if the menu hasn't been fully setup prior to selecting a
+        // menu item.

[tommycli, 2016/08/11 21:53:10]

I think the comment needs an update.

[dschuyler, 2016/08/11 22:40:14]

Done.

+        setupCategory(settings.ContentSettingsTypes.GEOLOCATION,
+            settings.PermissionValues.ALLOW, prefs);
+        return browserProxy.whenCalled('getExceptionList').then(function(
+            contentType) {
+          Polymer.dom.flush();
+          var menuItems = getMenuItems(testElement.$.listContainer);
+          assertTrue(!!menuItems);
+          MockInteractions.tap(menuItems[0]);

[tommycli, 2016/08/11 21:53:10]

After the tap, return browserProxy.whenCalled('resetCategoryPermission') or
browserProxy.whenCalled('setCategoryPermission'), to ensure that we 'wait' for
the test to go through the problematic section of code.

[dschuyler, 2016/08/11 22:40:14]

Done.

+        });
+      });
     });
   }
   return {
     registerTests: registerTests,
   };
 });