Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2230513002: fix #26155 - optional param passed to positional was not inferred (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf, vsm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #26155 - optional param passed to positional was not inferred R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/8e9b77dd4268378a41b401d7512238b3e58ff8d5

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +9 lines, -22 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-09 13:58:44 UTC) #2
vsm
lgtm
4 years, 4 months ago (2016-08-09 15:58:34 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-09 16:10:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8e9b77dd4268378a41b401d7512238b3e58ff8d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698