Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 22305004: Cleaned up nil comparisons in Hydrogen. (Closed)

Created:
7 years, 4 months ago by Sven Panne
Modified:
7 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Cleaned up nil comparisons in Hydrogen. This consists basically of 2 parts: * Restructured BuildCompareNil to make the logic behind it clearer. Note that it is intentionally written in a quite stylized way. * Replaced a usesless IfBuilder by a plain HInstruction, removing some empty blocks. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16266

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M src/hydrogen.cc View 1 2 chunks +33 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 4 months ago (2013-08-09 10:50:09 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-09 13:45:11 UTC) #2
Sven Panne
7 years, 4 months ago (2013-08-22 06:44:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16266.

Powered by Google App Engine
This is Rietveld 408576698