Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo
Patch Set: Michael's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index 454ec31285be638e7e4fcb456e462e093995a568..ad7f8a9f7c6a126e9636b004316c297b4066995f 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -36,11 +36,11 @@ class ContentSuggestionsService : public KeyedService,
class Observer {
public:
- // Fired every time the service receives a new set of data, replacing any
- // previously available data (though in most cases there will be an overlap
- // and only a few changes within the data). The new data is then available
- // through the getters of the service.
- virtual void OnNewSuggestions() = 0;
+ // Fired every time the service receives a new set of data for the given
+ // |category|, replacing any previously available data (though in most cases
+ // there will be an overlap and only a few changes within the data). The new
+ // data is then available through |GetSuggestionsForCategory(category)|.
+ virtual void OnNewSuggestions(Category category) = 0;
// Fired when the status of a suggestions category changed. When the status
// changes to an unavailable status, the suggestions of the respective
@@ -90,7 +90,8 @@ class ContentSuggestionsService : public KeyedService,
// Fetches the image for the suggestion with the given |suggestion_id| and
// runs the |callback|. If that suggestion doesn't exist or the fetch fails,
- // the callback gets an empty image.
+ // the callback gets an empty image. The callback will not be called
+ // synchronously.
void FetchSuggestionImage(const std::string& suggestion_id,
const ImageFetchedCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698