Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo
Patch Set: Michael's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 4b8632f8d4a465e4932f50b2963f9bc84f94a1bb..0129065e42a3b1d7fbffb3298dd9217d6000b7ac 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -18,16 +18,18 @@ import java.util.List;
*/
public class SuggestionsSection implements ItemGroup {
private final List<SnippetArticleListItem> mSuggestions = new ArrayList<>();
- private final SnippetHeaderListItem mHeader = new SnippetHeaderListItem();
+ private final SuggestionsCategoryInfo mInfo;
+ private final SnippetHeaderListItem mHeader;
private StatusListItem mStatus;
private final ProgressListItem mProgressIndicator = new ProgressListItem();
private final ActionListItem mMoreButton;
public SuggestionsSection(List<SnippetArticleListItem> suggestions,
- @CategoryStatusEnum int status, NewTabPageAdapter adapter, boolean showMoreButton) {
- mMoreButton = showMoreButton ? new ActionListItem() : null;
-
- // TODO(mvanouwerkerk): Pass in the header text.
+ @CategoryStatusEnum int status, SuggestionsCategoryInfo info,
+ NewTabPageAdapter adapter) {
+ mInfo = info;
+ mHeader = new SnippetHeaderListItem(mInfo.getTitle());
+ mMoreButton = null; // TODO(pke): Read from info => ? new ActionListItem() : null;
setSuggestions(suggestions, status, adapter);
}

Powered by Google App Engine
This is Rietveld 408576698