Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2230473002: Refactor and extend SnippetsBridge for multi-section support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@categoryinfo
Patch Set: Michael's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
index 0781498e04e232bdd5fbf4e71eb900c5c9a18f79..b158127fa726cb1c417e1c7c96386fa2f1974d05 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
@@ -146,10 +146,15 @@ public class NewTabPageRecyclerView extends RecyclerView {
* below the fold to push the header up to to the top of the screen.
*/
int calculateBottomSpacing() {
+ int firstHeaderPos = getNewTabPageAdapter().getFirstHeaderPosition();
int firstVisiblePos = mLayoutManager.findFirstVisibleItemPosition();
+ if (firstHeaderPos == RecyclerView.NO_POSITION
+ || firstVisiblePos == RecyclerView.NO_POSITION) {
+ return mMinBottomSpacing;
+ }
// We have enough items to fill the view, since the snap point item is not even visible.
- if (firstVisiblePos > getNewTabPageAdapter().getFirstHeaderPosition()) {
+ if (firstVisiblePos > firstHeaderPos) {
return mMinBottomSpacing;
}

Powered by Google App Engine
This is Rietveld 408576698