Chromium Code Reviews| Index: components/ntp_snippets/content_suggestions_service.h |
| diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h |
| index 454ec31285be638e7e4fcb456e462e093995a568..fd15df83efeb32f50ae7a6ef38359e39029850f3 100644 |
| --- a/components/ntp_snippets/content_suggestions_service.h |
| +++ b/components/ntp_snippets/content_suggestions_service.h |
| @@ -36,11 +36,11 @@ class ContentSuggestionsService : public KeyedService, |
| class Observer { |
| public: |
| - // Fired every time the service receives a new set of data, replacing any |
| - // previously available data (though in most cases there will be an overlap |
| - // and only a few changes within the data). The new data is then available |
| - // through the getters of the service. |
| - virtual void OnNewSuggestions() = 0; |
| + // Fired every time the service receives a new set of data for the given |
| + // |category|, replacing any previously available data (though in most cases |
| + // there will be an overlap and only a few changes within the data). The new |
| + // data is then available through |GetSuggestionsForCategory(category)|. |
| + virtual void OnNewSuggestions(Category category) = 0; |
| // Fired when the status of a suggestions category changed. When the status |
| // changes to an unavailable status, the suggestions of the respective |
| @@ -90,7 +90,8 @@ class ContentSuggestionsService : public KeyedService, |
| // Fetches the image for the suggestion with the given |suggestion_id| and |
| // runs the |callback|. If that suggestion doesn't exist or the fetch fails, |
| - // the callback gets an empty image. |
| + // the callback gets an empty image. The callback must not be called |
|
Marc Treib
2016/08/09 14:42:57
and here
Philipp Keck
2016/08/09 16:59:16
Done.
|
| + // synchronously. |
| void FetchSuggestionImage(const std::string& suggestion_id, |
| const ImageFetchedCallback& callback); |