content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | ui/touch_selection/touch_selection_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index f29806a0d39156454381aaea89f7707545793c88..f8a044ac2bf90f35fba37d55e5cf043e802f5d93 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -259,7 +259,6 @@ std::unique_ptr<ui::TouchSelectionController> CreateSelectionController(

config.max_tap_duration = base::TimeDelta::FromMilliseconds(

gfx::ViewConfiguration::GetLongPressTimeoutInMs());

config.tap_slop = gfx::ViewConfiguration::GetTouchSlopInDips();

- config.show_on_tap_for_empty_editable = false;

config.enable_adaptive_handle_orientation =

base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableAdaptiveSelectionHandleOrientation);

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | ui/touch_selection/touch_selection_controller_unittest.cc » ('J')