LayoutTests/media/track/track-cue-empty-crash.html - Issue 22304002: Crash when calling getCueAsHTML() on a TextTrackCue with empty text

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-cue-empty-crash.html

Issue 22304002: Crash when calling getCueAsHTML() on a TextTrackCue with empty text (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

	5

	6 <script src=../media-file.js></script>

	7 <script src=../video-test.js></script>

	8 <script>

	9 var fragment;

	10 function startTest()

	11 {

	12 var emptyCue = new TextTrackCue(0, 0, "");
	acolwell GONE FROM CHROMIUM 2013/08/05 23:40:32 Should passing null also behave the same way? If s Should passing null also behave the same way? If so it might be nice to cover that case as well. vcarbune.chromium 2013/08/09 18:47:26 null is converted to the string "null" and further Show quoted text On 2013/08/05 23:40:32, acolwell wrote: > Should passing null also behave the same way? If so it might be nice to cover > that case as well. null is converted to the string "null" and further processed like that - I'd say this is appropriate, as it's the default handling in JavaScript
	13 fragment = emptyCue.getCueAsHTML();

	14

	15 consoleWrite(" The getCueAsHTML() method should return a document fragment ");

	16 testExpected("fragment", null, "!=");

	17 testExpected("fragment.children.length", 0);

	18

	19 consoleWrite("");

	20 consoleWrite("No crash. PASS.");

	21 consoleWrite("");

	22

	23 endTest();

	24 }

	25 </script>

	26 </head>

	27

	28 <body onload="startTest()">

	29 <p>Tests that having an empty cue does not crash when calling getCueAsHT ML().</p>

	30 <video controls />

	31 </body>

	32 </html>

OLD	NEW