Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: ui/views/mus/text_input_client_impl.cc

Issue 2230393002: IME for Mus: Make InputMethodMus use the IME Mojo API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify unittests to cover non-char events. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/mus/text_input_client_impl.cc
diff --git a/ui/views/mus/text_input_client_impl.cc b/ui/views/mus/text_input_client_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5662b760924ff89b2f51ebb66a5b627d9a249ce9
--- /dev/null
+++ b/ui/views/mus/text_input_client_impl.cc
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/views/mus/text_input_client_impl.h"
+
+#include "ui/base/ime/text_input_client.h"
+#include "ui/views/mus/input_method_mus.h"
+
+namespace views {
+
+TextInputClientImpl::TextInputClientImpl(ui::TextInputClient* text_input_client,
+ InputMethodMus* input_method)
+ : text_input_client_(text_input_client),
+ input_method_(input_method),
+ binding_(this) {}
+
+TextInputClientImpl::~TextInputClientImpl() {}
+
+ui::mojom::TextInputClientPtr TextInputClientImpl::CreateInterfacePtrAndBind() {
+ return binding_.CreateInterfacePtrAndBind();
+}
+
+void TextInputClientImpl::OnCompositionEvent(
+ ui::mojom::CompositionEventPtr event) {
+ switch (event->type) {
+ case ui::mojom::CompositionEventType::INSERT_CHAR: {
+ ui::KeyEvent* key_event = (*event->key_event)->AsKeyEvent();
+ if (key_event->is_char())
sadrul 2016/08/18 03:57:58 This should be a DCHECK()? Why would we get INSERT
+ text_input_client_->InsertChar(*key_event);
+ break;
+ }
+ case ui::mojom::CompositionEventType::CONFIRM:
+ text_input_client_->ConfirmCompositionText();
+ break;
+ case ui::mojom::CompositionEventType::CLEAR:
+ text_input_client_->ClearCompositionText();
+ break;
+ case ui::mojom::CompositionEventType::UPDATE:
+ case ui::mojom::CompositionEventType::INSERT_TEXT:
+ // TODO(moshayedi): crbug.com/631524. Implement these types of composition
+ // events once we have the necessary fields in ui.mojom.CompositionEvent.
+ NOTIMPLEMENTED();
+ break;
+ }
+}
+
+void TextInputClientImpl::OnUnhandledEvent(
+ std::unique_ptr<ui::Event> key_event) {
+ DCHECK(key_event && key_event->IsKeyEvent());
+ input_method_->DispatchKeyEventPostIME(key_event->AsKeyEvent());
sadrul 2016/08/18 03:57:58 Ideally, ui::TextInputClient would know how to dea
+}
+
+} // namespace views

Powered by Google App Engine
This is Rietveld 408576698