Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2230383003: Implement @patch annotation for patch class members (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement @patch annotation for patch class members Allow members of patch classes to be annotated with @patch. The VM ignores the annotation. I simply replaces the original method if the name matches, or reports an error if field names match. Adding a bit is_patched to members to do more checking remains a TODO. There are currently no unused bits available, and I don’t want to increase the size of Function objects for this. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1a6d1eca3260a8ad270e8fe02457c1da3945cb6b

Patch Set 1 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -233 lines) Patch
M runtime/bin/common_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory_patch.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M runtime/bin/eventhandler_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_patch.dart View 3 chunks +16 lines, -16 lines 0 comments Download
M runtime/bin/file_system_entity_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/filter_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/io_service_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/platform_patch.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M runtime/bin/process_patch.dart View 6 chunks +14 lines, -14 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/socket_patch.dart View 6 chunks +14 lines, -14 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/lib/array_patch.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/bool_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/collection_patch.dart View 7 chunks +10 lines, -10 lines 0 comments Download
M runtime/lib/convert_patch.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/date_patch.dart View 4 chunks +23 lines, -23 lines 0 comments Download
M runtime/lib/deferred_load_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/double_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/errors_patch.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/expando_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/function_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/lib/integers_patch.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 16 chunks +21 lines, -21 lines 0 comments Download
M runtime/lib/map_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/math_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/mirrors_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/object_patch.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/profiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/resource_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/schedule_microtask_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/stopwatch_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/string_buffer_patch.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/lib/string_patch.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/lib/symbol_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/timer_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/uri_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/lib/vmservice_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hausner
This unifies the patch syntax for dart2js and the VM.
4 years, 4 months ago (2016-08-10 17:56:01 UTC) #4
siva
lgtm
4 years, 4 months ago (2016-08-10 19:41:58 UTC) #5
hausner
4 years, 4 months ago (2016-08-10 19:55:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
1a6d1eca3260a8ad270e8fe02457c1da3945cb6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698