Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java

Issue 223033002: Fix for 16134- class members modify the set of members that are inherited from superclasses. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
index 0eab1934fbfba0fdbbaa04ede1be0c1f2bbcbd72..71b7df78d07e5dcc9a3ce407a6a33ad6bb95a371 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
@@ -1440,6 +1440,57 @@ public class NonErrorResolverTest extends ResolverTestCase {
verify(source);
}
+ public void test_inconsistentMethodInheritance_overrideTrumpsInherits_getter() throws Exception {
+ // 16134
+ Source source = addSource(createSource(//
+ "class B<S> {",
+ " S get g => null;",
+ "}",
+ "abstract class I<U> {",
+ " U get g => null;",
+ "}",
+ "class C extends B<double> implements I<int> {",
+ " num get g => null;",
+ "}"));
+ resolve(source);
+ assertNoErrors(source);
+ verify(source);
+ }
+
+ public void test_inconsistentMethodInheritance_overrideTrumpsInherits_method() throws Exception {
+ // 16134
+ Source source = addSource(createSource(//
+ "class B<S> {",
+ " m(S s) => null;",
+ "}",
+ "abstract class I<U> {",
+ " m(U u) => null;",
+ "}",
+ "class C extends B<double> implements I<int> {",
+ " m(num n) => null;",
+ "}"));
+ resolve(source);
+ assertNoErrors(source);
+ verify(source);
+ }
+
+ public void test_inconsistentMethodInheritance_overrideTrumpsInherits_setter() throws Exception {
+ // 16134
+ Source source = addSource(createSource(//
+ "class B<S> {",
+ " set t(S s) {}",
+ "}",
+ "abstract class I<U> {",
+ " set t(U u) {}",
+ "}",
+ "class C extends B<double> implements I<int> {",
+ " set t(num n) {}",
+ "}"));
+ resolve(source);
+ assertNoErrors(source);
+ verify(source);
+ }
+
public void test_inconsistentMethodInheritance_simple() throws Exception {
Source source = addSource(createSource(//
"abstract class A {",

Powered by Google App Engine
This is Rietveld 408576698