In recording benches, record to and from the same format.

In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

This makes it easier to profile SkLiteDL and explore both recording and playback overhead hot spots.

The threadsafety is incidental for the source (and doesn't affect playback speed),
but I think it's handy to keep around on the destination to make a more fair comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002

Committed: https://skia.googlesource.com/skia/+/1d65fe293241cfeb405b1724371d6c532bcee55f

[mtklein_C, 2016-08-10 15:59:35]

Description was changed from

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
==========

to

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002
==========

[mtklein, 2016-08-10 16:00:12]

Description was changed from

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002
==========

to

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

This makes it easier to profile SkLiteDL and explore both recording and playback
overhead hot spots.

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002
==========

[mtklein_C, 2016-08-10 16:00:54]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-08-10 16:00:54]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-08-10 19:08:51]

lgtm

[commit-bot: I haz the power, 2016-08-10 19:09:36]

Description was changed from

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

This makes it easier to profile SkLiteDL and explore both recording and playback
overhead hot spots.

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002
==========

to

==========
In recording benches, record to and from the same format.

The recording bench must record some source material into some sort of
display list, and fundamentally cannot separate the timing of the two.

This CL makes it so the source material and display list are of the same type.

So instead of previous:
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkRecord-based picture -> threadsafe SkLiteDL

Now this times
   --nolite: SkRecord-based picture -> SkRecord-based picture
     --lite: SkLiteDL -> threadsafe SkLiteDL

This makes it easier to profile SkLiteDL and explore both recording and playback
overhead hot spots.

The threadsafety is incidental for the source (and doesn't affect playback
speed),
but I think it's handy to keep around on the destination to make a more fair
comparison.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230323002

Committed:
https://skia.googlesource.com/skia/+/1d65fe293241cfeb405b1724371d6c532bcee55f
==========

[commit-bot: I haz the power, 2016-08-10 19:09:37]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d65fe293241cfeb405b1724371d6c532bcee55f