Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: tools/turbolizer/graph-layout.js

Issue 2230313002: [turbolizer] Enlarge node labels and bubbles. Fix dead node display on old JSON. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@t-p2-base
Patch Set: Fix arrowheads. Fix dead nodes on old JSONs. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/turbolizer/edge.js ('k') | tools/turbolizer/graph-view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/turbolizer/graph-layout.js
diff --git a/tools/turbolizer/graph-layout.js b/tools/turbolizer/graph-layout.js
index 9986639a6330fb0879e6791dc110dfe16a816a71..e9b44b4d2cdf267fbf3d0e2680cf80ddd03c712d 100644
--- a/tools/turbolizer/graph-layout.js
+++ b/tools/turbolizer/graph-layout.js
@@ -371,7 +371,7 @@ function layoutNodeGraph(graph) {
var rankSets = [];
// Collect sets for each rank.
graph.nodes.forEach(function(n, i){
- n.y = n.rank * (DEFAULT_NODE_ROW_SEPARATION + graph.getNodeHeight() +
+ n.y = n.rank * (DEFAULT_NODE_ROW_SEPARATION + graph.getNodeHeight(n) +
2 * DEFAULT_NODE_BUBBLE_RADIUS);
if (n.visible) {
if (rankSets[n.rank] === undefined) {
@@ -482,8 +482,8 @@ function redetermineGraphBoundingBox(graph) {
if ((node.y - 50) < graph.minGraphY) {
graph.minGraphY = node.y - 50;
}
- if ((node.y + graph.getNodeHeight() + 50) > graph.maxGraphY) {
- graph.maxGraphY = node.y + graph.getNodeHeight() + 50;
+ if ((node.y + graph.getNodeHeight(node) + 50) > graph.maxGraphY) {
+ graph.maxGraphY = node.y + graph.getNodeHeight(node) + 50;
}
}
« no previous file with comments | « tools/turbolizer/edge.js ('k') | tools/turbolizer/graph-view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698