Issue 2230313002: [turbolizer] Enlarge node labels and bubbles. Fix dead node display on old JSON.

Issue 2230313002: [turbolizer] Enlarge node labels and bubbles. Fix dead node display on old JSON. (Closed)

Created:
4 years, 4 months ago by bgeron

Modified:
4 years, 4 months ago

Reviewers:
danno

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@t-p2-base

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbolizer] Enlarge node labels and bubbles. Fix dead node display on old JSON. BUG= Committed: https://crrev.com/ec9465eb9becef5e4e8add3e7b4e7f6134b1874e Cr-Commit-Position: refs/heads/master@{#38588}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -34 lines)			Patch
M	tools/turbolizer/edge.js	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/turbolizer/graph-layout.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/turbolizer/graph-view.js	View	1 2	11 chunks	+35 lines, -22 lines	0 comments	Download
M	tools/turbolizer/node.js	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	tools/turbolizer/turbo-visualizer.css	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 13 (5 generated)

danno

Getting there... I see that the edges between the nodes are not quite aligned with ...

4 years, 4 months ago (2016-08-10 17:26:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230313002/40001

4 years, 4 months ago (2016-08-11 16:12:59 UTC) #9

commit-bot: I haz the power

4 years, 4 months ago (2016-08-11 16:46:30 UTC) #13

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/ec9465eb9becef5e4e8add3e7b4e7f6134b1874e
Cr-Commit-Position: refs/heads/master@{#38588}