Remove Error cards for content suggestions, error case refine behavior

Remove Error cards for content suggestions, error case refine behavior

A ContentSuggestionsProvider can report error statuses for its
Categories, three of which are relevant for the UI. The reaction of the
UI is different depending on whether an NTP showing the respective
section is already open or not.

Already opened NTPs will keep displaying if the status changes to
NOT_PROVIDED. Dismissing/fetching images and other things don't work in
that scenario, but the section stays on the UI. For LOADING_ERROR
and CATEGORY_EXPLICITLY_DISABLED, the corresponding section immediately
disappears from the UI. For newly opened NTPs, we don't show any
section in all those three cases.

Remove the ErrorListItem, because we now never display error messages
on the NTP (for hard, unfixable errors; other errors like the user not
being signed in are still displayed as regular status cards).

BUG=629817
Committed: https://crrev.com/29d9c568816f149ab93ca015971f0696ee0d4386
Cr-Commit-Position: refs/heads/master@{#411659}

[Philipp Keck, 2016-08-10 17:10:22]

pke@google.com changed reviewers:
+ bauerb@chromium.org

[Philipp Keck, 2016-08-10 17:10:23]

PTAL

Tested the following cases:
Opening a new NTP doesn't show sections with NOT_PROVIDED,
CATEGORY_EXPLICITLY_DISABLED or LOADING_ERROR at all.
Sections stay on the NTP when the provider spontaneously switches their status
to NOT_PROVIDED.
Sections are immediately removed if the status switches to
CATEGORY_EXPLICITLY_DISABLED or LOADING_ERROR.
The NTP has no below-the-fold and no scrolling if no sections are available.

[Bernhard Bauer, 2016-08-10 17:21:15]

lgtm

[Philipp Keck, 2016-08-10 18:02:18]

On 2016/08/10 17:21:15, Bernhard Bauer wrote:
> lgtm

I extended the NewTabPageAdapterTest to test these new cases automatically.
Removed the test parts for the loading indicator in those three cases, because
the loading indicator (along with the entire section) would be removed anyway.

[Philipp Keck, 2016-08-12 08:41:45]

On 2016/08/10 18:02:18, Philipp Keck wrote:
> On 2016/08/10 17:21:15, Bernhard Bauer wrote:
> > lgtm
> 
> I extended the NewTabPageAdapterTest to test these new cases automatically.
> Removed the test parts for the loading indicator in those three cases, because
> the loading indicator (along with the entire section) would be removed anyway.

And again the test has changed. PTAL again.

[Bernhard Bauer, 2016-08-12 09:05:15]

On 2016/08/12 08:41:45, Philipp Keck wrote:
> On 2016/08/10 18:02:18, Philipp Keck wrote:
> > On 2016/08/10 17:21:15, Bernhard Bauer wrote:
> > > lgtm
> > 
> > I extended the NewTabPageAdapterTest to test these new cases automatically.
> > Removed the test parts for the loading indicator in those three cases,
because
> > the loading indicator (along with the entire section) would be removed
anyway.
> 
> And again the test has changed. PTAL again.

LGTM (assuming https://codereview.chromium.org/2232783002/ is going to go
through in its current form, otherwise you'll have to rebase).

[Philipp Keck, 2016-08-12 14:36:05]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-12 14:36:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2230303003/#ps80001
(title: "Rebase (should be no change)")

[commit-bot: I haz the power, 2016-08-12 14:36:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 15:40:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 15:41:58]

Description was changed from

==========
Remove Error cards for content suggestions, error case refine behavior

A ContentSuggestionsProvider can report error statuses for its
Categories, three of which are relevant for the UI. The reaction of the
UI is different depending on whether an NTP showing the respective
section is already open or not.

Already opened NTPs will keep displaying if the status changes to
NOT_PROVIDED. Dismissing/fetching images and other things don't work in
that scenario, but the section stays on the UI. For LOADING_ERROR
and CATEGORY_EXPLICITLY_DISABLED, the corresponding section immediately
disappears from the UI. For newly opened NTPs, we don't show any
section in all those three cases.

Remove the ErrorListItem, because we now never display error messages
on the NTP (for hard, unfixable errors; other errors like the user not
being signed in are still displayed as regular status cards).

BUG=629817
==========

to

==========
Remove Error cards for content suggestions, error case refine behavior

A ContentSuggestionsProvider can report error statuses for its
Categories, three of which are relevant for the UI. The reaction of the
UI is different depending on whether an NTP showing the respective
section is already open or not.

Already opened NTPs will keep displaying if the status changes to
NOT_PROVIDED. Dismissing/fetching images and other things don't work in
that scenario, but the section stays on the UI. For LOADING_ERROR
and CATEGORY_EXPLICITLY_DISABLED, the corresponding section immediately
disappears from the UI. For newly opened NTPs, we don't show any
section in all those three cases.

Remove the ErrorListItem, because we now never display error messages
on the NTP (for hard, unfixable errors; other errors like the user not
being signed in are still displayed as regular status cards).

BUG=629817

Committed: https://crrev.com/29d9c568816f149ab93ca015971f0696ee0d4386
Cr-Commit-Position: refs/heads/master@{#411659}
==========

[commit-bot: I haz the power, 2016-08-12 15:41:59]

Patchset 5 (id:??) landed as
https://crrev.com/29d9c568816f149ab93ca015971f0696ee0d4386
Cr-Commit-Position: refs/heads/master@{#411659}