Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 22303003: test.py: Use different path to dartanalyzer on windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index e61ab50f1a84617a68760f30b01c4964f5322fcd..e09d153bf2e98ad1791f394863e4b35901301f66 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1192,6 +1192,8 @@ class RunningProcess {
}
class BatchRunnerProcess {
+ static bool isWindows = io.Platform.operatingSystem == 'windows';
+
final batchRunnerTypes = {
'selenium' : {
'run_executable' : 'python',
@@ -1199,11 +1201,15 @@ class BatchRunnerProcess {
'terminate_command' : ['--terminate'],
},
'dartanalyzer' : {
- 'run_executable' : 'sdk/bin/dartanalyzer_developer', // $suffix
+ 'run_executable' :
+ isWindows ?
+ 'sdk\\bin\\dartanalyzer_developer.bat'
+ : 'sdk/bin/dartanalyzer_developer',
'run_arguments' : ['--batch'],
'terminate_command' : null,
},
'dart2analyzer' : {
+ // This is a unix shell script, no windows equivalent available
'run_executable' : 'editor/tools/analyzer_experimental',
'run_arguments' : ['--batch'],
'terminate_command' : null,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698