Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: runtime/vm/code_descriptors_test.cc

Issue 22303002: Auto create ApiLocalScope before calling native functions, this ensures that (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_descriptors_test.cc
===================================================================
--- runtime/vm/code_descriptors_test.cc (revision 25778)
+++ runtime/vm/code_descriptors_test.cc (working copy)
@@ -182,7 +182,6 @@
static void NativeFunc(Dart_NativeArguments args) {
- Dart_EnterScope();
Dart_Handle i = Dart_GetNativeArgument(args, 0);
Dart_Handle k = Dart_GetNativeArgument(args, 1);
int64_t value = -1;
@@ -191,7 +190,6 @@
EXPECT_VALID(Dart_IntegerToInt64(k, &value));
EXPECT_EQ(20, value);
Isolate::Current()->heap()->CollectAllGarbage();
- Dart_ExitScope();
}
@@ -283,4 +281,3 @@
}
} // namespace dart
-

Powered by Google App Engine
This is Rietveld 408576698